Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nginx delay #309

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Add nginx delay #309

wants to merge 13 commits into from

Conversation

beelchester
Copy link
Contributor

Signed-off-by: Sahil Yeole <[email protected]>
Signed-off-by: Sahil Yeole <[email protected]>
Signed-off-by: Sahil Yeole <[email protected]>
Signed-off-by: Sahil Yeole <[email protected]>
@neo773
Copy link
Contributor

neo773 commented Jul 8, 2024

CI already takes like half an hour to run, compiling nginx from source would double that time.
Aren't there prebuilt nginx binaries with echo module?

Signed-off-by: Sahil Yeole <[email protected]>
Signed-off-by: Sahil Yeole <[email protected]>
@beelchester
Copy link
Contributor Author

beelchester commented Jul 8, 2024

Thanks, I've now used openresty instead, which is recommended for echo module.

@tusharmath
Copy link
Contributor

I don't think this is working moving to draft until everything is fixed.

@tusharmath tusharmath marked this pull request as draft July 10, 2024 08:34
Signed-off-by: Sahil Yeole <[email protected]>
@beelchester beelchester marked this pull request as ready for review July 15, 2024 05:24
@neo773
Copy link
Contributor

neo773 commented Jul 15, 2024

@beelchester
Won't lua have an overhead?

@beelchester
Copy link
Contributor Author

I don’t think it will cause any significant overhead.
Also, for benchmarking, relative performance matters.

@beelchester beelchester marked this pull request as draft July 16, 2024 04:44
@beelchester beelchester marked this pull request as ready for review July 16, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants