Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch: .github/workflows #47

Open
bradfitz opened this issue Feb 9, 2023 · 2 comments
Open

patch: .github/workflows #47

bradfitz opened this issue Feb 9, 2023 · 2 comments
Labels
tsgo

Comments

@bradfitz
Copy link
Member

bradfitz commented Feb 9, 2023

Summary: add the .github/workflows directory for Tailscale
Upstream status: not applicable. Forever forked.
Example prior commit: 4865b81

When cherry-picking that commit, be sure to add additional tailscale.go1.NN branches to build.yml as needed.
@bradfitz bradfitz added the tsgo label Feb 9, 2023
@bradfitz
Copy link
Member Author

bradfitz commented Feb 9, 2023

Actually, when cherry-picking this, don't. Instead just tar up the old directory and re-add it to the new tree. Otherwise don't forget any other edits to it, e.g. 954407f.

bradfitz pushed a commit that referenced this issue Apr 18, 2023
@ianlancetaylor @gopherbot
cmd/link: don't emit PAX_FLAGS segment on Linux
ffb07d0 
We started emitting this segment in 2012 in CL 6326054 for #47.
It disabled three kinds of protection: mprotect, randexec, and emutramp.
The randexec protection was deprecated some time ago, replaced by PIE.
The emutramp and mprotect protection was because we used to rely on being
able to create writable executable memory to implement function closures,
but that is not true since https://go.dev/s/go11func was implemented.

Change-Id: I5e3a5279d76d642b0423d26195b891479a235763
Reviewed-on: https://go-review.googlesource.com/c/go/+/471199
Run-TryBot: Ian Lance Taylor <[email protected]>
Auto-Submit: Ian Lance Taylor <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Cherry Mui <[email protected]>
@phirework phirework mentioned this issue Jun 21, 2023
Merged
bradfitz added a commit that referenced this issue Aug 21, 2024
@bradfitz
[tailscale] add .github
d09f29d 
Updates #47
bradfitz added a commit that referenced this issue Aug 21, 2024
@bradfitz
[tailscale] add .github
c994ff5 
Updates #47
mpminardi added a commit that referenced this issue Jan 7, 2025
@mpminardi
[tailscale] .github: bump to latest ubuntu LTS in workflows
244608e 
Use `ubuntu-24.04` instead of `20.04` as the latter is EOL in May 2025.

Updates #47

Signed-off-by: Mario Minardi <[email protected]>
@mpminardi mpminardi mentioned this issue Jan 7, 2025
Merged
mpminardi added a commit that referenced this issue Jan 29, 2025
@mpminardi
[tailscale] .github: bump to latest ubuntu LTS in workflows
9d8d324 
Use `ubuntu-24.04` instead of `20.04` as the latter is EOL in May 2025.

Updates #47

Signed-off-by: Mario Minardi <[email protected]>
mpminardi added a commit that referenced this issue Jan 29, 2025
@mpminardi
[tailscale] .github: stop using upload-release-asset action
dd73862 
Change to use `action-gh-release` instead of `upload-release-asset` as
the repo for `upload-release-asset` is in public archive and recommends
swapping over to `action-gh-release`.

Updates #47

Signed-off-by: Mario Minardi <[email protected]>
@mpminardi mpminardi mentioned this issue Jan 29, 2025
Open
mpminardi added a commit that referenced this issue Jan 29, 2025
@mpminardi
[tailscale] .github: stop using upload-release-asset action
f77eb7c 
Change to use `action-gh-release` instead of `upload-release-asset` as
the repo for `upload-release-asset` is in public archive and recommends
swapping over to `action-gh-release`.

Updates #47

Signed-off-by: Mario Minardi <[email protected]>
mpminardi added a commit that referenced this issue Jan 29, 2025
@mpminardi
[tailscale] .github: stop using create-relase and upload-release-asset
11aeb3d 
Change to use `action-gh-release` instead of the `create-release`
and `upload-release-asset` actions as the repos for these actions are in
public archive and recommend swapping over to `action-gh-release`.

Updates #47

Signed-off-by: Mario Minardi <[email protected]>
@bradfitz
Copy link
Member Author

Example updating ts1.24 from the old go1.24 gitbub files:

$ git restore --source=tailscale.go1.23 .github/workflows .github/dependabot.yml
$ git add .github/workflows .github/dependabot.yml

bradfitz added a commit that referenced this issue Feb 13, 2025
@bradfitz
[tailscale] add Tailscale .github files (#47)
076d555 
Signed-off-by: Brad Fitzpatrick <[email protected]>
bradfitz added a commit that referenced this issue Feb 13, 2025
@bradfitz
[tailscale] add Tailscale .github files (#47)
a529f1c 
Signed-off-by: Brad Fitzpatrick <[email protected]>
mpminardi added a commit that referenced this issue Feb 26, 2025
@mpminardi
.github/workflows: remove build pruning
14efeeb 
Remove pruning of old builds to ensure that we can use `tool/go` in our
repos with for older revisions when `TS_USE_TOOLCHAIN` is enabled.

Updates #47

Signed-off-by: Mario Minardi <[email protected]>
@mpminardi mpminardi mentioned this issue Feb 26, 2025
Merged
bradfitz pushed a commit that referenced this issue Feb 26, 2025
@mpminardi @bradfitz
[tailscale] .github: bump to latest ubuntu LTS in workflows
69a12b0 
Use `ubuntu-24.04` instead of `20.04` as the latter is EOL in May 2025.

Updates #47

Signed-off-by: Mario Minardi <[email protected]>
mpminardi added a commit that referenced this issue Feb 26, 2025
@mpminardi
.github/workflows: remove build pruning
9326f58 
Remove pruning of old builds to ensure that we can use `tool/go` in our
repos with for older revisions when `TS_USE_TOOLCHAIN` is enabled.

Updates #47

Signed-off-by: Mario Minardi <[email protected]>
mpminardi added a commit that referenced this issue Feb 27, 2025
@mpminardi
.github/workflows: add skipTests option
e651af5 
Add `skipTests` option to build.yml to allow for skipping tests in
extraordinary circumstances.

Updates #47

Signed-off-by: Mario Minardi <[email protected]>
@mpminardi mpminardi mentioned this issue Feb 27, 2025
Merged
mpminardi added a commit that referenced this issue Feb 27, 2025
@mpminardi
.github/workflows: add skipTests option
b27f1c6 
Add `skipTests` option to build.yml to allow for skipping tests in
extraordinary circumstances.

Updates #47

Signed-off-by: Mario Minardi <[email protected]>
mpminardi added a commit that referenced this issue Feb 27, 2025
@mpminardi
.github/workflows: ensure that create_release runs if we skip tests
b7c5a81 
Add logic to ensure that `create_release` is run if we are intentionally
skipping tests.

Updates #47

Signed-off-by: Mario Minardi <[email protected]>
@mpminardi mpminardi mentioned this issue Feb 27, 2025
Merged
mpminardi added a commit that referenced this issue Feb 27, 2025
@mpminardi
.github/workflows: add always() logic to upload_release job
6350d75 
It seems like using the `always()` hack in an upstream `needs`
dependency may force downstream jobs to also use `always()`, presumably
because GitHub is doing transitive dependency checking upstream and sees
that the original `test` job was skipped.

Updates #47

Signed-off-by: Mario Minardi <[email protected]>
@mpminardi mpminardi mentioned this issue Feb 27, 2025
Merged
mpminardi added a commit that referenced this issue Feb 27, 2025
@mpminardi
.github/workflows: add always() logic to upload_release job
e88bd4a 
Add `always()` logic to `upload_release` job as it seems like using the
`always()` hack in an upstream `needs` dependency may force downstream
jobs to also use `always()`, presumably because GitHub is doing
transitive dependency checking upstream and sees that the original
`test` job was skipped.

Pass explicit `commitsh` argument to the `create-release` action to
ensure the resulting tag / release is tied to the intended SHA and not
the branch the job was triggered from. As an example, before this change
triggering the workflow from the `tailscale.go1.24` branch would always
result in the tag being added to the head of `tailscale.go1.24` instead
of at the `ref` that the release was actually built from.

Updates #47

Signed-off-by: Mario Minardi <[email protected]>
mpminardi added a commit that referenced this issue Mar 4, 2025
@mpminardi
.github/workflows: use a GitHub app token for create-release
0e66990 
Use a GitHub application token for create-release to give it the
necessary permissions to do historical releases.

Updates #47
Updates tailscale/corp#26875

Signed-off-by: Mario Minardi <[email protected]>
@mpminardi mpminardi mentioned this issue Mar 4, 2025
Merged
mpminardi added a commit that referenced this issue Mar 5, 2025
@mpminardi
.github/workflows: embed SHA from checkout instead of github.sha
b650425 
Embed the commit SHA that we have checked out instead of `github.sha`
into `mod.go` at build time as `github.sha` will point to the incorrect
commit when running as a workflow_dispatch with `ref` specified.

Updates #47
Updates tailscale/corp#26875

Signed-off-by: Mario Minardi <[email protected]>
@mpminardi mpminardi mentioned this issue Mar 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tsgo
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bradfitz