Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch: net: add TS_PANIC_ON_TEST_LISTEN_UNSPEC env to panic on unspecified addr listens #48

Open
bradfitz opened this issue Feb 9, 2023 · 1 comment
Open

patch: net: add TS_PANIC_ON_TEST_LISTEN_UNSPEC env to panic on unspecified addr listens #48

bradfitz opened this issue Feb 9, 2023 · 1 comment
Labels
ts24 tsgo

Comments

@bradfitz
Copy link
Member

bradfitz commented Feb 9, 2023

Summary: add env knob to net package panic if test code does a listen on the unspecified address
Upstream status: upstream not interested.
Importance: not important. We could drop this if we wanted. But it's convenient when needed, to debug Mac/Windows firewall issues during tests.
Example prior commit: 8c9eff4
@bradfitz bradfitz added the tsgo label Feb 9, 2023
@phirework phirework mentioned this issue Jun 21, 2023
Merged
bradfitz pushed a commit that referenced this issue Feb 13, 2025
@josharian @bradfitz
[tailscale] net: add TS_PANIC_ON_TEST_LISTEN_UNSPEC env to panic on u…
27518da 
…nspecified addr listens

For debugging Mac firewall dialog boxes blocking+failing tests.

Updates #48

Change-Id: Ic1a0cd51de7fe553de1c1c9333fa1cc75b8490f2
(cherry picked from commit cd7323c)
(cherry picked from commit 8c9eff4)
@bradfitz
Copy link
Member Author

ts1.23: 179980e
ts1.24: 27518da

@bradfitz bradfitz added the ts24 label Feb 13, 2025
bradfitz pushed a commit that referenced this issue Feb 13, 2025
@josharian @bradfitz
[tailscale] net: add TS_PANIC_ON_TEST_LISTEN_UNSPEC env to panic on u…
66fc9da 
…nspecified addr listens

For debugging Mac firewall dialog boxes blocking+failing tests.

Updates #48

Change-Id: Ic1a0cd51de7fe553de1c1c9333fa1cc75b8490f2
(cherry picked from commit cd7323c)
(cherry picked from commit 8c9eff4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ts24 tsgo
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bradfitz