Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

png + xmp? #3

Open
s3rj1k opened this issue Mar 21, 2018 · 5 comments
Open

png + xmp? #3

s3rj1k opened this issue Mar 21, 2018 · 5 comments

Comments

@s3rj1k
Copy link

s3rj1k commented Mar 21, 2018

add png support with xmp?

@tajtiattila
Copy link
Owner

That would be easy to implement, but I use this package mainly on my photos and videos, I don't have actual PNG files to work with.

Are you interested in implementing this, or do you have PNG files for testing?

@s3rj1k
Copy link
Author

s3rj1k commented Mar 22, 2018

Hi @tajtiattila, thanks for quick response.

I am interested in using your package to add custom XMP metadata to photo archive, they will be in PNG and JPEG format.

Will be great if you could add support for png add add simple example on how to use this.

I would gladly test. thanks.

@tajtiattila
Copy link
Owner

Writing new metadata in MP4 or png would be easy, but writing XMP isn't implemented yet. This would require an XML package that can encode data it has decoded with correct namespace prefixes. This is a known problem with the current encoding/xml package, have a look at the many issues in the go project: golang/go#13400

@s3rj1k
Copy link
Author

s3rj1k commented Mar 27, 2018

@tajtiattila there is https://github.com/trimmer-io/go-xmp that could help with marshalling XMP

@tajtiattila
Copy link
Owner

Thank you, this might work. However, the package has to be cleaned up first based on a container and metadata registry before adding new container types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants