Skip to content
This repository has been archived by the owner on Sep 26, 2022. It is now read-only.

Flip locators endianness #296

Open
sr-gi opened this issue Jun 30, 2021 · 0 comments
Open

Flip locators endianness #296

sr-gi opened this issue Jun 30, 2021 · 0 comments

Comments

@sr-gi
Copy link
Member

sr-gi commented Jun 30, 2021

Currently we are constructing locators using the big-endian representation of the dispute txid, given data is always queried to bitcoind and that's the format used to display data.

However, transaction ids are internally represented as little-endian, so this may be an issue when trying to integrate with other software that, internally, represents sha256d hashes in the same way as bitcoind does.

Therefore, locators may be better computed using the internal endianness representation (i.e. little-endian).

PS: double-checked with @Roasbeef and lnd does compute hints using little-endian txids.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant