Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build a tower client for LDK #133

Open
2 tasks
sr-gi opened this issue Oct 17, 2022 · 11 comments
Open
2 tasks

Build a tower client for LDK #133

sr-gi opened this issue Oct 17, 2022 · 11 comments

Comments

@sr-gi
Copy link
Member

sr-gi commented Oct 17, 2022

Let's build for LDK:

  • Add tower logic to LDK sample (or a fork ok it)
  • Create a simple code snippet that can be plugged into any project building on top of LDK
@sr-gi
Copy link
Member Author

sr-gi commented Sep 14, 2023

This should now be possible (lightningdevkit/rust-lightning#2337)

@moneyball
Copy link

Any takers? :)

@aruokhai
Copy link

aruokhai commented Mar 7, 2024

Taking it as part of Bitcoin FOSS Program

@sr-gi
Copy link
Member Author

sr-gi commented Mar 7, 2024

In case it is useful, this is a (really outdated) test of the PR adding tower support to LDK:
sr-gi/ldk-sample@4af2914
lightningdevkit/rust-lightning#2337 (comment)

@aruokhai
Copy link

aruokhai commented Apr 24, 2024

@sr-gi, i face lots of bitcoin and lightning libraries incompatibility issues while implementing Ldk-integeration. The incompatibility issue arises due to my need to use Locator, Appointment, UserId structures, among others which resides in teos-common module The needed changes in rust-lightning was added in v0.0.119 , which depends on rust-bitcoin ^0.30.2, while teos-common depends on lightning = "0.0.108" and bitcoin = "0.28.0". Currently i am working a new branch to update bitcoin and lightning libraries, what do you think ?

@dzdidi
Copy link

dzdidi commented Jan 23, 2025

@aruokhai any updates on you can share?

@dzdidi
Copy link

dzdidi commented Feb 3, 2025

Here is the PR #268 to address #133 (comment)

@adamjonas
Copy link

https://github.com/aruokhai/Watchdog/tree/ldk-integration

cc @aruokhai

@dzdidi
Copy link

dzdidi commented Feb 4, 2025

@sr-gi from what I understand, the first part is already implemented as rust-teos is using LDK internally. But it is the second part, teos client for ldk which is missing. Is this correct?

@aruokhai started with https://github.com/aruokhai/Watchdog/tree/ldk-integration but there seem to be no progress for some months now so if nobody objects I would like to take it on from here.

I would need help in getting up to speed. So far it seems that big part of client's logic like https://github.com/talaia-labs/rust-teos/blob/master/watchtower-plugin/src/net/http.rs and https://github.com/talaia-labs/rust-teos/blob/master/watchtower-plugin/src/retrier.rs should be possible to reuse.

However, I noticed that @aruokhai's work relies on KV storage instead of SQLite. So, I would appreciate it if @moneyball could help clarify the storage and client's API requirements or recommendations

@tnull
Copy link

tnull commented Feb 4, 2025

However, I noticed that @aruokhai's work relies on KV storage instead of SQLite. So, I would appreciate it if @moneyball could help clarify the storage and client's API requirements or recommendations

From a first look it seems like it's using LDK's KVStore, so should be more implementation-independent in general (even though the filestore.rs naming indicates otherwise). Please feel free to ping me on LDK Discord to discuss how such an integration could look like going forward and where we could take that branch from here (that is, assuming the original author is fine with you taking it over, of course).

@aruokhai
Copy link

aruokhai commented Feb 4, 2025

Hey @dzdidi , you are free to work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants