Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsx detect maps support may fail #110

Open
leoliu opened this issue May 13, 2017 · 4 comments
Open

jsx detect maps support may fail #110

leoliu opened this issue May 13, 2017 · 4 comments

Comments

@leoliu
Copy link

leoliu commented May 13, 2017

Might be a bug in rebar3 instead. But I got a crash because jsx is returning [{,}] instead of the expected maps that I always prefer.

In a project that uses jsx. I am doing this with OTP 20-rc1.

rebar3 clean --all
rebar3 as prod release

check that function jsx:maps_support/0 returns false.

However, the following will detect maps support correctly.

rebar3 clean --all
rebar3 compile
rebar3 as prod release
@talentdeficit
Copy link
Owner

i haven't had a chance to test with otp20 yet but i can't reproduce this with 19.x

does JSX_FORCE_MAPS=true rebar3 as prod release work?

@leoliu
Copy link
Author

leoliu commented May 15, 2017

no. It appears rebar.config.script is by-passed.

@leoliu leoliu closed this as completed Jun 21, 2017
@leoliu leoliu reopened this Jun 21, 2017
@paulo-ferraz-oliveira
Copy link
Contributor

Is this still an issue in the newer rebar3 versions (e.g. latest)?

@leoliu
Copy link
Author

leoliu commented Sep 12, 2020

maybe not since I haven't seen this issue for 2-3 years.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants