Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidated PR and CRAN update #84

Open
klaukh opened this issue Feb 17, 2018 · 3 comments
Open

Consolidated PR and CRAN update #84

klaukh opened this issue Feb 17, 2018 · 3 comments

Comments

@klaukh
Copy link
Contributor

klaukh commented Feb 17, 2018

@jcheng5, I realize you're quite busy with other projects and... per the note on the repo... are not actively maintaining this package. I'm curious if there's a path forward for incorporating updates and fixes, either through an en masse PR via another fork or through adding additional maintainers. As a starter, I've been steadily perusing through the network, PRs, and issues and incorporating many of the primary ones - color labels, NA values, axis positioning, d3 version protection - plus new features like a new API plus a shiny gadget. I would offer a comprehensive PR - with an eye towards a new CRAN submission - but want to first check to see what thoughts you might have. I'm partial to this heatmap implementation for performance and aethestic reasons, as I know others are as well, so would like to see if there's a path forward.

WIth all that said: thoughts / recommendations?

@jcheng5
Copy link
Collaborator

jcheng5 commented Feb 17, 2018

Sure, that'd be great!

@klaukh
Copy link
Contributor Author

klaukh commented Feb 17, 2018

Cool. I'll start the cataloging and polishing then intiate the PR.

@klaukh
Copy link
Contributor Author

klaukh commented Mar 24, 2018

@jcheng5 The PR is up... #86. Not being pushy, just want to make sure it reaches your inbox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants