Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined name: path in _compute_statistics_of_path() #90

Open
cclauss opened this issue Mar 12, 2020 · 0 comments
Open

Undefined name: path in _compute_statistics_of_path() #90

cclauss opened this issue Mar 12, 2020 · 0 comments

Comments

@cclauss
Copy link
Contributor

cclauss commented Mar 12, 2020

https://github.com/tamarott/SinGAN/blob/master/SIFID/sifid_score.py#L208-L219

flake8 testing of https://github.com/tamarott/SinGAN on Python 3.8.1

$ flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics

./SIFID/sifid_score.py:209:8: F821 undefined name 'path'
    if path.endswith('.npz'):
       ^
./SIFID/sifid_score.py:210:21: F821 undefined name 'path'
        f = np.load(path)
                    ^
./SIFID/sifid_score.py:214:29: F821 undefined name 'path'
        path = pathlib.Path(path)
                            ^
3     F821 undefined name 'path'
3

https://flake8.pycqa.org/en/latest/user/error-codes.html

On the flake8 test selection, this PR does not focus on "style violations" (the majority of flake8 error codes that psf/black can autocorrect). Instead these tests are focus on runtime safety and correctness:

  • E9 tests are about Python syntax errors usually raised because flake8 can not build an Abstract Syntax Tree (AST). Often these issues are a sign of unused code or code that has not been ported to Python 3. These would be compile-time errors in a compiled language but in a dynamic language like Python they result in the script halting/crashing on the user.
  • F63 tests are usually about the confusion between identity and equality in Python. Use ==/!= to compare str, bytes, and int literals is the classic case. These are areas where a == b is True but a is b is False (or vice versa). Python >= 3.8 will raise SyntaxWarnings on these instances.
  • F7 tests logic errors and syntax errors in type hints
  • F82 tests are almost always undefined names which are usually a sign of a typo, missing imports, or code that has not been ported to Python 3. These also would be compile-time errors in a compiled language but in Python a NameError is raised which will halt/crash the script on the user.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant