Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.1.0 has no longer support Angular 11 #134

Open
begandroide opened this issue Nov 11, 2021 · 14 comments
Open

4.1.0 has no longer support Angular 11 #134

begandroide opened this issue Nov 11, 2021 · 14 comments

Comments

@begandroide
Copy link

Hi! Today I upgrade ngx-mat-intl-tel-input from 4.0.0 to 4.1.0 and the application not compile because a lot of errors.

image

@venraij
Copy link
Contributor

venraij commented Nov 11, 2021

I'm using the package in an angular 12 project as well, and it has no issues at all. Have you tried deleting your node_modules folder and installing them all again? You could also try this in combination with deleting the lock file. It is possible there is something wrong in the dependencies.

@begandroide
Copy link
Author

@venraij thanks you for response. Yes, I deleted node_modules folder and install again and same error, we found the problem in CI pipeline, where install is in cleaned up folder. So I downgrade to 4.0.0 and all works fine again. I'm going to check again.

@venraij
Copy link
Contributor

venraij commented Nov 11, 2021

What seems strange to me is that it's trying to go into @angular/core/core, that path does not exist.

@venraij
Copy link
Contributor

venraij commented Nov 11, 2021

It's also never imported like that. For example:
image

@begandroide
Copy link
Author

I understand, checking again.

@begandroide
Copy link
Author

@venraij my apologizes, the angular version in my project is 11.2.4 and not 12. So I will change the name of the issue.

We have in roadmap upgrade to angular 12 so by the moments we can use 4.0.0.

@begandroide begandroide changed the title 4.1.0 has no longer support Angular 12 4.1.0 has no longer support Angular 11 Nov 11, 2021
@venraij
Copy link
Contributor

venraij commented Nov 11, 2021

I've just locally tested in angular version 11.2.4, no issues at all again. Are you sure there isn't something else going wrong in your project?

image

@venraij
Copy link
Contributor

venraij commented Nov 11, 2021

The 4.1.0 update doesn't involve big changes though besides the angular 13 upgrade. So there is not much reason to put a lot of time into it.

@begandroide
Copy link
Author

@venraij did you install ngx-mat-intl-tel-input? I didn't see it in your package.json

@venraij
Copy link
Contributor

venraij commented Nov 11, 2021

Yes, this is the testing project within the repo. I downgraded it to ng 11 for testing. It seems to work fine.

@begandroide
Copy link
Author

ok, i will check and report here. Thanks for you help 😄

@begandroide
Copy link
Author

@venraij the issue apparently is related with npm registry, I provide an StackBlitz repro link:

https://stackblitz.com/edit/angular-ivy-grjm68?file=src/app/app.component.ts

@venraij venraij mentioned this issue Nov 12, 2021
@venraij
Copy link
Contributor

venraij commented Nov 12, 2021

I've created a fix #136

@begandroide
Copy link
Author

thanks you @venraij !! i will check when new version is available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants