Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Standardize No Data Value vs Zero Value Display #2831

Open
monaiuu opened this issue Feb 19, 2025 · 0 comments
Open

[TASK] Standardize No Data Value vs Zero Value Display #2831

monaiuu opened this issue Feb 19, 2025 · 0 comments
Assignees

Comments

@monaiuu
Copy link
Contributor

monaiuu commented Feb 19, 2025

Description

We need to establish a standardized way to clearly make distinction between no data values and actual zero values across our UI.

No Data (—)

  • When the value is null/undefined
  • When the data hasn't loaded yet
  • When the value is not applicable for this context
  • When there's an error fetching the data

Zero (0)

  • When we have successfully fetched the data and it's explicitly zero
  • When a calculation results in zero

Current Issues

In the Restake Vaults table we have inconsistent usage:

  1. "Available" column: Uses mix of '0' and '—' for empty values; should be '0'
  2. "Deposits" column: Uses '—' for empty values, should be '0'
  3. "TVL | Capacity" column: Uses '—' for empty values, should be '0'

In the account component;

  1. Rewards and Points: Uses '—' for empty values, should be '0'

Screenshot

Image
@monaiuu monaiuu converted this from a draft issue Feb 19, 2025
@monaiuu monaiuu changed the title [TASK] Standardize Empty Value vs Zero Value Display [TASK] Standardize No Data Value vs Zero Value Display Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Planning 🗺️
Development

No branches or pull requests

2 participants