-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Add Support for Master Blueprint Service Manager #830
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 11 out of 11 changed files in this pull request and generated no suggestions.
Note: The huge diff in the latest commit is from the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 11 out of 15 changed files in this pull request and generated no suggestions.
Files not reviewed (4)
- pallets/services/src/mock.rs: Evaluated as low risk
- precompiles/services/src/tests.rs: Evaluated as low risk
- tangle-subxt/Cargo.toml: Evaluated as low risk
- runtime/testnet/src/tangle_services.rs: Evaluated as low risk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would love to see more tests, more edge cases, looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 17 out of 17 changed files in this pull request and generated no suggestions.
Summary of changes
This pull request introduces several significant changes to the
pallets/services/src/lib.rs
file, focusing on enhancing the management of Master Blueprint Service Managers and refining various hooks and dispatchable functions. The most important changes are summarized below:Enhancements to Master Blueprint Service Manager
MaxMasterBlueprintServiceManagerVersions
to define the maximum number of versions allowed for Master Blueprint Service Managers.MasterBlueprintServiceManagerRevisions
to store all revisions of the Master Blueprint Service Manager.update_master_blueprint_service_manager
to update the Master Blueprint Service Manager and emit an event upon revision.BlueprintCreationInterrupted
,MasterBlueprintServiceManagerRevisionNotFound
, andMaxMasterBlueprintServiceManagerVersionsExceeded
to handle specific error cases. [1] [2]Modifications to Hooks and Dispatchable Functions
create_blueprint
function to handle Master Blueprint Service Manager revisions and ensure the blueprint creation process is not interrupted.on_register_hook
,on_unregister_hook
,on_update_price_targets
,on_request_hook
,on_approve_hook
,on_service_init_hook
,on_reject_hook
,on_service_termination_hook
,on_job_call_hook
,on_job_result_hook
) to includeblueprint_id
as a parameter for better context and validation. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]Removal of Deprecated Events
EvmLog
event to clean up the event definitions.Mock Runtime Adjustments
MaxMasterBlueprintServiceManagerRevisions
in the mock runtime configuration to support the new functionality.MaxMasterBlueprintServiceManagerVersions
and changed the origin for updating the Master Blueprint Service Manager toEnsureRoot
.These changes collectively improve the flexibility and robustness of the service management module by allowing for better version control and validation of blueprints and their associated hooks.
Reference issue to close (if applicable)
Closes #828