You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm using nippy without any compression. It would be nice to exclude the dependencies that are (I think) only required for compression, and keep the dependency footprint smaller. At the moment, if I exclude these dependencies, then compilation fails. I guess the code could be re-worked to dynamically reference classes in these libs? Happy to experiment with this and do a pull request if you think it is acceptable to do this.
Use reflective calls to interact with org.tukaani/xz and io.airlift/aircompressor so that users of nippy can choose
to exclude those dependencies if they aren't using compression.
Reflective calls are much slower, and some type-hints were also removed, so these changes might affect performance.
I quickly put a pull-request together, just to show you what it would look like before refining anything too much. I'm concerned that these changes might affect performance, which is obviously a big deal, so benchmarking definitely required.
I'm using nippy without any compression. It would be nice to exclude the dependencies that are (I think) only required for compression, and keep the dependency footprint smaller. At the moment, if I exclude these dependencies, then compilation fails. I guess the code could be re-worked to dynamically reference classes in these libs? Happy to experiment with this and do a pull request if you think it is acceptable to do this.
nippy/project.clj
Lines 13 to 14 in 5a9a391
The text was updated successfully, but these errors were encountered: