Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Person.tags doesn't always return a Highrise::Tag array #57

Open
basvodde opened this issue Apr 14, 2014 · 0 comments
Open

Person.tags doesn't always return a Highrise::Tag array #57

basvodde opened this issue Apr 14, 2014 · 0 comments

Comments

@basvodde
Copy link
Collaborator

The current tags implementation (in taggable) uses get(:tags) which returns a Hash and not a Highrise::Tag. This causes trouble when adding tags and retrieving them later.

There are probably two solutions:

  1. Pass the Hash to a create of the Highrise::Tag and return that (ugly)
  2. Do a find instead of a get, so that the Hash gets recordized.

Other ideas welcome :) Fixed it locally but it breaks the taggable behavior as defined by the current specs, so will need more work before doing a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant