Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate further sorting of the nodes in user base case #193

Open
dburov190 opened this issue Oct 14, 2020 · 0 comments
Open

Investigate further sorting of the nodes in user base case #193

dburov190 opened this issue Oct 14, 2020 · 0 comments

Comments

@dburov190
Copy link
Collaborator

First, it wouldn't hurt to understand whether Ollie's fix in ContactNetwork.__convert_array_to_dict solved the correct issue. I'm just not sure it wouldn't affect something else that relies on nodes being consecutive integers, for example.

Second, the error that Jinlong pointed out seems to stem from something else (index out of bounds in line 155 in populations.py). At least it's not clear to me why the fix in ContactNetwork.__convert_array_to_dict would fix it. I believe, to fix Jinlong's error it would be enough to write in lines 29-30 of _master_eqn_init.py:

        transition_rates = TransitionRates.from_samplers(
                population=network.get_node_count(),

instead of

        transition_rates = TransitionRates.from_samplers(
                population=user_network.get_node_count(),

but I'm not sure.

I'm basically making notes to myself to clear it up later; we've had enough of "ah, it works, whatever" moments that turn into "oh, this is clearly not the way it was supposed to be!" moments, so I wanna make sure everything is as expected.

@dburov190 dburov190 changed the title Investigate further sorting of the nodes in user base Investigate further sorting of the nodes in user base case Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant