Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KG 0.32 - Refactor logging #12

Open
NotChristianGarcia opened this issue Jun 13, 2022 · 0 comments
Open

KG 0.32 - Refactor logging #12

NotChristianGarcia opened this issue Jun 13, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@NotChristianGarcia
Copy link
Member

Logging was done very quickly, needs to be thought out more though. Currently logging is running read_namespaced_pod_log with the Kubernetes python client. This gives us all current logs for the pod, up to the maximum Kubernetes itself stores (10 MB by default). Meaning when we update the pod's logs, we always have the latest 10 MB of logs.

Two possible problems:

  • We'll lose logs. Might be useful to have the entirety of a pods logs, thinking in the case of week/month long pod runs.
  • There might be a lot of churn, this would mean updating 10 MB of logs in the database every time health runs (a lot). At the least, it would be useful to have a function to only append with the diff of logs.
  • Bonus problem. If a pod is stopped and restarted, currently we would lose the first instances logs. That might not be preferred.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Progress
Development

No branches or pull requests

1 participant