test: support tests with vshard #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need use `box.info.replication.uuid` instead of `box.info.cluster.uuid` to support Tarantool 3.0 [1]. 1. tarantool/tarantool#8289 Part of #366 Closes #371
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-364-vshard-tests
branch
from
69b5862
to
c7d1d22
Compare
|
There are 3 red tests in |
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-364-vshard-tests
branch
from
c7d1d22
to
bc306c7
Compare
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-364-vshard-tests
branch
3 times, most recently
from
5057af4
to
3e6023b
Compare
The patch updates all tests to work with `vshard` and `cartridge` at the same time. But tests of the `cartridge` role of the cartridge or special features are skipping for `vshard`. If `cartridge` is not installed or not supported (Tarantool 3.0+), tests will run only with `vshard`. The source of `vshard_helpers` folder is `vshard` repository [1] with minor modifications. 1. https://github.com/tarantool/vshard/tree/b3c27b32637863e9a03503e641bb7c8c69779a00/test/luatest_helpers Closes #364
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-364-vshard-tests
branch
from
3e6023b
to
e52c470
Compare
Added a workaround with the triggers removing before a space drop. Now the tests work with all versions of Taranatool. |
DifferentialOrange
approved these changes
Oct 9, 2023
oleg-jukovec
added a commit
to tarantool/tarantool
that referenced
this pull request
Oct 9, 2023
The patch returns integration test run with `crud`. The test run was removed earlier [1] because the `crud` did not support tests with Tarantool 3.0. But now it supports [2]. 1. 7316d81 2. tarantool/crud#381 NO_DOC=ci NO_TEST=ci NO_CHANGELOG=ci
ylobankov
pushed a commit
to tarantool/tarantool
that referenced
this pull request
Oct 9, 2023
The patch returns integration test run with `crud`. The test run was removed earlier [1] because the `crud` did not support tests with Tarantool 3.0. But now it supports [2]. 1. 7316d81 2. tarantool/crud#381 NO_DOC=ci NO_TEST=ci NO_CHANGELOG=ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch updates all tests to work with
vshardandcartridgeat the same time. But tests of thecartridgerole of the cartridge or special features are skipping forvshard.If
cartridgeis not installed or not supported (Tarantool 3.0+), tests will run only withvshard.The source of
vshard_helpersfolder isvshardrepository [1] with minor modifications.I didn't forget about
Closes #364
Closes #371