storage: fix send/recv unprotected when 2 at once #441
+233
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is taking too long time (> 30 seconds). The commit moves it to a separate file so as the more generic test storage_1_1 wouldn't be too slow. The latter is going to get new test cases and it is easier to debug them when the info-test is in another place. Needed for #429 NO_DOC=refactoring
Gerold103
force-pushed
the
gerold103/gh-434-transfering_buckets-bug
branch
from
20589b0
to
b689df2
Compare
Serpentian
reviewed
Oct 31, 2023
If more than one bucket_send/recv would try to start on the same bucket on the same storage, it could lead to the bucket recovery or GC when there would be no need for it. Data couldn't be lost, and it wouldn't occur during automatic rebalancing, but manual usage of those functions could fail when it shouldn't have. Closes #434 NO_DOC=bugfix
Gerold103
force-pushed
the
gerold103/gh-434-transfering_buckets-bug
branch
from
b689df2
to
4168ac7
Compare
Serpentian
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is for #434, and the first commit is cherry-picked from #439 to speed up the tests.