-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-asking Human message duplicates the message #587
Comments
This bug seems to have been introduced in 7cc1e2f When you enter a valid web handler URL, ChatCraft responds with a User message with the web handler output: I think the changes in 7cc1e2f will send any re-asked message to the web handler, and if it's not a web handler target, ChatCraft will respond with a User message containing text identical to the re-asked message. Investigating possible solutions now |
Console.log() statements ChatBase.tsx::215 and inside if condition at ChatBase::216 confirms non-web handler targets aren't passed to webHandler. Still investigating, but it looks like because we're now passing the prompt text from the |
Still working on this, but won't be finished by the deadline. I have a fix in mind. Will hopefully make a PR tomorrow |
any updates on this? |
I'll have a PR ready tonight. |
When studying this I noticed the duplication only occurs with a regular prompt, but to determine an ideal fix I had to study how other kinds of re-ask actions were affected by 7cc1e2f (e.g. slash commands, web handlers). Below are the observations I've made.
These observations suggest the only thing that should be fixed is regular prompt messages being duplicated, the PR will be ready shortly. |
I noticed when editing and re-asking a message, ChatCraft duplicates my updated message:
The text was updated successfully, but these errors were encountered: