Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "loggf cut" in levels_lines.py doesn't work as intended #419

Open
andrewfullard opened this issue Nov 4, 2024 · 0 comments
Open

The "loggf cut" in levels_lines.py doesn't work as intended #419

andrewfullard opened this issue Nov 4, 2024 · 0 comments
Labels

Comments

@andrewfullard
Copy link
Contributor

andrewfullard commented Nov 4, 2024

This will arise after #414 is merged. I added the ability to use the A_ul Einstein coefficient from the Chianti data directly in the case where gf is zero (and thus loggf = -inf). The inverse should also be true, retaining the original behaviour of Carsus i.e. that the lines with low loggf are cut. It is likely that this breaks for CMFGEN data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant