Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add erzaehlmirnix (again) #105

Closed
wants to merge 5 commits into from
Closed

Add erzaehlmirnix (again) #105

wants to merge 5 commits into from

Conversation

Olf0
Copy link
Contributor

@Olf0 Olf0 commented Mar 10, 2020

Add erzaehlmirnix, now from Facebook.

Original PNGs:

@Olf0 Olf0 mentioned this pull request Mar 10, 2020
@Olf0
Copy link
Contributor Author

Olf0 commented Mar 12, 2020

The background of the original cover.v3.png PNG still has to be flood-filled with the RGB background colour dddfde from the info.json file, saved and then upscaled to 1000x1000 px².
Both PNGs then have to be exported as JPEGs again and uploaded to replace the extant cover_big.v3.jpg and cover.v3.jpg.

As I currently lack access to an image manipulation software with which this can be accomplished easily, this may take a while.

@Olf0
Copy link
Contributor Author

Olf0 commented Mar 14, 2020

@Olf0 Olf0 marked this pull request as ready for review March 15, 2020 18:57
@Maledictus
Copy link
Collaborator

Maledictus commented Mar 16, 2020

It's the same comics as emoticomix but in de language. I'm not sure that we should add the same comics in different languages as two different comics. I'm going to merge only en version but we can create issue about adding multilanguage support to application
P.S.
We already have #17 and #54 . If I have time I will do it in the next release

@Olf0
Copy link
Contributor Author

Olf0 commented Mar 16, 2020

It's the same comics as emoticomix but in de language.

Rather the opposite: erzaehlmirnix is the original version, its author started to translate most of the new strips and publish them as emoticomix recently. Note, that emoticomix is not a third party translation, it is the author who releases most of her strips also in English.

I'm not sure that we should add the same comics in different languages as two different comics.

As soon as an alternative mechanism for multi-language comics is implemented (solving issues #17 and #54), I will gladly convert erzaehlmirnix and emoticomix to a shared base and provide two language options (DE and EN) for it.

Note that the erzaehlmirnix's requirements for this mechanism are:

  • Primary / original language can be arbitrarily set (here: to DE)
  • The names of the different language versions differ (also true for some other comic strips, for which translations are available)
  • Hence different cover images must be used (as they may include names or words, which vary between languages)

If you plan to make a release of DailyComics, before a multi-language mechanism fulfilling these requirements is implemented, please include both, erzaehlmirnix and emoticomix.
If you insist in including only one of them for now, please include the original (erzaehlmirnix) instead of its (sometimes strangely translated) English version (emoticomix).

I will retain both branches, until we have found a working solution for both, erzaehlmirnix and emoticomix.

@Olf0
Copy link
Contributor Author

Olf0 commented Nov 16, 2021

Stopped working, and I failed to make it working again, neither from Facebook or from Twitter.

@Olf0 Olf0 closed this Nov 16, 2021
Olf0 added a commit to sailfishos-applications/daily-comics that referenced this pull request Sep 30, 2023
* Add erzaehlmirnix (again)
  Add erzaehlmirnix, now from Facebook.

* Add erzaehlmirnix (again)

* Add files via upload

* Add files via upload

* Finalised cover(s)
  See PR tardypad#105
@Olf0 Olf0 deleted the patch-4 branch September 30, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants