Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reaping by POD_STATUS_PHASES - Pending, Running, Succeeded, Failed, Unknown #94

Merged
merged 3 commits into from
Nov 22, 2024

Conversation

Antvirf
Copy link
Contributor

@Antvirf Antvirf commented Nov 18, 2024

Enables the reaping of pods by the more familiar pod 'Status' logic (Pending, Running, Succeeded, Failed, Unknown), which in the underlying implementation is pod.Status.Phase. Built in a very similar way to the existing code used for pod.Status and should follow the repo's current conventions.

Please let me know if there's other things we need to adapt to make this work / any other required amendments. IMO the existing docs for POD_PHASES should be amended for clarity, I can add that to this PR if you'd like.

Ref #65

@brianberzins
Copy link
Collaborator

Want to say: this looks great.

I can't for the life of me remember why I used reason over pod.Status.Phase but I swear there was one.
It seems likely that reason is now defunct, so I'm honestly not going to worry about it.

Can you do me a favor and add an entry in the CHANGELOG.md with a new version number? This doesn't break anything, so minor version/second number should be sufficient. Then I'll get this merged and deployed for you!

@Antvirf
Copy link
Contributor Author

Antvirf commented Nov 19, 2024

Thanks @brianberzins , I've just pushed a commit bumping to 2.14.0.

@brianberzins brianberzins merged commit 13a2480 into target:master Nov 22, 2024
2 checks passed
@brianberzins
Copy link
Collaborator

Done! Sorry for slow response on the update.
Got lost in the github notification flood.

2.14.0 is released up on dockerhub.

https://hub.docker.com/layers/target/pod-reaper/2.14.0/images/sha256-940b80fa1660700a9e8e64aa8e27936d0805ddc8b5c80943d36261e17ff99b1e?context=explore

let me know how it works out for you!

@Antvirf Antvirf deleted the feat/pod-status-phase branch November 22, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants