Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize and validate variable scalars, ints, others for to_windows, shift, round, and similar methods #20

Open
tariqshihadah opened this issue Mar 27, 2024 · 1 comment · Fixed by #21

Comments

@tariqshihadah
Copy link
Owner

Multiple methods take inputs of either a single scalar/int/other value, an array of the same, or a reference to a column label in the events dataframe whose values get pulled to satisfy the input. Validation of this should be pulled out in a separate hidden validation method that can generically validate any of these input types, returning a standardized array.

@tariqshihadah
Copy link
Owner Author

Added a generic method and applied to to_windows and shift for application test case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant