You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The method appears to duplicate some validation and data processing and may be best simplified. Instead of validating RangeCollection-like input, applying the intersect method, and then distributing it, it should instead take an input consistent with the output of the intersection, distributing as normal from there.
This will require refactoring of the code in the associated call in linref. It may be best to remove the distribute feature from the merge module entirely, applying it as a processing feature for data already present in the events data frame. This will require some deprecation warning.
The text was updated successfully, but these errors were encountered:
Also need to consider, what are the expectations for order, adjacency, and overlap for ranges being distributed over? Is there adequate validation for this?
The method appears to duplicate some validation and data processing and may be best simplified. Instead of validating
RangeCollection
-like input, applying theintersect
method, and then distributing it, it should instead take an input consistent with the output of the intersection, distributing as normal from there.This will require refactoring of the code in the associated call in
linref
. It may be best to remove the distribute feature from themerge
module entirely, applying it as a processing feature for data already present in the events data frame. This will require some deprecation warning.The text was updated successfully, but these errors were encountered: