Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate intersection from distribute method #2

Open
tariqshihadah opened this issue Nov 30, 2024 · 1 comment
Open

Separate intersection from distribute method #2

tariqshihadah opened this issue Nov 30, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@tariqshihadah
Copy link
Owner

The method appears to duplicate some validation and data processing and may be best simplified. Instead of validating RangeCollection-like input, applying the intersect method, and then distributing it, it should instead take an input consistent with the output of the intersection, distributing as normal from there.

This will require refactoring of the code in the associated call in linref. It may be best to remove the distribute feature from the merge module entirely, applying it as a processing feature for data already present in the events data frame. This will require some deprecation warning.

@tariqshihadah
Copy link
Owner Author

Also need to consider, what are the expectations for order, adjacency, and overlap for ranges being distributed over? Is there adequate validation for this?

@tariqshihadah tariqshihadah added the enhancement New feature or request label Nov 30, 2024
@tariqshihadah tariqshihadah self-assigned this Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant