Memory leak in SNTP sync

[ThomasNauwelaerts]

picotcp/modules/pico_sntp_client.c

Line 469 in 4caf650

int pico_sntp_sync(const char *sntp_server, void (*cb_synced)(pico_err_t status))

When performing a SNTP sync there is a memory leak of about 1k.
I'm at the latest version of the stack.

[ThomasNauwelaerts]

Edit: as the leakage remains when using pico_sntp_sync_ip, this has nothing to do with the pico_sntp_sync_start_dns_ipv4 routine.

[ThomasNauwelaerts]

Seems like in the function pico_sntp_client_wakeup we need to close the socket. Where else will the socket get closed?

picotcp/modules/pico_sntp_client.c

Line 180 in 4caf650

PICO_FREE(recvbuf);

@frederikvs Could you verify this? Is it a solution to just add pico_socket_close(s); and pico_socket_del(s); to PICO_SOCK_EV_RD? Or do we need to close the socket in the other events also?

[ThomasNauwelaerts]

@danielinux Maybe you could take a look at this?