Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Remove invalid autostart during the uninstallation process #12422

Open
ProjectNyaser opened this issue Jan 16, 2025 · 7 comments · May be fixed by #12643
Open

[feat] Remove invalid autostart during the uninstallation process #12422

ProjectNyaser opened this issue Jan 16, 2025 · 7 comments · May be fixed by #12643
Assignees
@animeshchaudhri
Labels
good first issue Good for newcomers platform: Windows scope: bundler The bundler used in our cli to make installers type: feature request

Comments

@ProjectNyaser
Copy link

ProjectNyaser commented Jan 16, 2025 •
edited
Loading

Describe the problem

在 Windows 11 通过 tauri-plugin-autostart 开启自启动后，执行 uninstall.exe 将程序卸载，此时仍然会有一个无效启动项被保留，是否可以将其在卸载过程中一并删除呢？

[AI Translation] When a program is set to autostart on Windows 11 using tauri-plugin-autostart and then uninstalled via uninstall.exe, an invalid startup entry often persists in the registry. Can this entry be removed during the uninstallation process?

Describe the solution you'd like

当自启动启用后，注册表 HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Run 下会新建一个项，卸载后这个项仍旧会被保留，或许卸载程序可以考虑将此项一并删除？

[AI Translation] When autostart is enabled for a program, a new registry key is created at HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Run. Upon uninstallation, this registry key may persist. It would be beneficial if uninstallers were modified to remove this registry key during the uninstallation process.

Alternatives considered

No response

Additional context

No response
@FabianLars FabianLars added good first issue Good for newcomers platform: Windows scope: bundler The bundler used in our cli to make installers labels Jan 16, 2025
@animeshchaudhri
Copy link

Hey @FabianLars can I work on this issue?

@FabianLars
Copy link
Member

sure thing! your help is much appreciated. To make it a bit easier, here is a PR that did something similar for another regkey #12427 (nsis only)

@animeshchaudhri
Copy link

@FabianLars I am able to reproduce the issue , but I need some help setting up Tauri locally so I can test it before submitting a pull request. Any docs to setup the installer locally ?

@FabianLars
Copy link
Member

Obviosuly first you have to clone tauri. For these changes here all you probably care about are the files in /crates/tauri-bundler (like in the link above). Once you did some changes you can go into the /crates/tauri-cli directory and run cargo install --debug --path . and then go into your test app and run cargo tauri build or cargo tauri build --debug to generate the test installers.

@animeshchaudhri animeshchaudhri linked a pull request Feb 7, 2025 that will close this issue
Open
@animeshchaudhri
Copy link

@FabianLars Hey can you review the pr

@ProjectNyaser
Copy link
Author

@FabianLars PR review requested~

@FabianLars
Copy link
Member

😒

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@animeshchaudhri animeshchaudhri

Labels
good first issue Good for newcomers platform: Windows scope: bundler The bundler used in our cli to make installers type: feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(uninstaller): remove autostart entry during uninstallation animeshchaudhri/tauri
3 participants
@FabianLars @ProjectNyaser @animeshchaudhri