Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Window builder physical size/position #5228

Open
WilliamVenner opened this issue Sep 18, 2022 · 6 comments · May be fixed by #5381
Open

[feat] Window builder physical size/position #5228

WilliamVenner opened this issue Sep 18, 2022 · 6 comments · May be fixed by #5381
Labels
good first issue Good for newcomers scope: core Core packages of Tauri status: backlog Issue is ready and we can work on it type: feature request

Comments

@WilliamVenner
Copy link
Contributor

Describe the problem

There's no way to set the size and position of the window in the window builder to physical coordinates.

Describe the solution you'd like

The size and position methods should be able to accept either logical or physical units.

Alternatives considered

Setting the window size and position AFTER the window has been created, which for some reason accepts logical or physical coordinates despite the fact that the window builder doesn't? 🤔

Additional context

My use case is positioning a window on a specific monitor. This can only be done with physical units :(
@amrbashir amrbashir added good first issue Good for newcomers scope: core Core packages of Tauri status: backlog Issue is ready and we can work on it labels Sep 19, 2022
@ysinsane
Copy link

ysinsane commented Oct 2, 2022 •
edited
Loading

Hi, I am working on this issue. I plan to add some config fields about size and position.

  1. physical_width: Option
  2. physical_height: Option
  3. physical_x: Option
  4. physical_y: Option
    And I will use these values to overide those corresponding config without physical if any of those values is not None.

ysinsane pushed a commit to ysinsane/tauri that referenced this issue Oct 10, 2022
feat: allow setting window size and position using physical units, close
1bf3067 
 tauri-apps#5228
ysinsane pushed a commit to ysinsane/tauri that referenced this issue Oct 10, 2022
feat: allow setting window size and position using physical units, close
f8c2b1e 
 tauri-apps#5228
ysinsane pushed a commit to ysinsane/tauri that referenced this issue Oct 10, 2022
feat: allow setting window size and position using physical units, close
2c53921 
 tauri-apps#5228
@ysinsane ysinsane linked a pull request Oct 10, 2022 that will close this issue
Open
13 tasks
@ysinsane
Copy link

Hi, may I ask if you need the set position pixel unit and size unit seperately or you just want a total switch?

@WilliamVenner
Copy link
Contributor Author

Ideally these functions should take tauri::Size or tauri::Position

https://docs.rs/tauri/latest/tauri/window/struct.WindowBuilder.html#method.inner_size

https://docs.rs/tauri/latest/tauri/window/struct.WindowBuilder.html#method.min_inner_size

https://docs.rs/tauri/latest/tauri/window/struct.WindowBuilder.html#method.max_inner_size

https://docs.rs/tauri/latest/tauri/window/struct.WindowBuilder.html#method.position

Unfortunately that would be a breaking change... so I don't really know what would be best here

@amrbashir
Copy link
Member

for now just add inner_size_physical, min_inner_size_physical...and so on, and we can change it in v2 to take either LogicalSize or PhysicalSize

ysinsane pushed a commit to ysinsane/tauri that referenced this issue Oct 11, 2022
feat: allow setting window size and position using physical units close
58c5188 
tauri-apps#5228
@amrbashir amrbashir mentioned this issue Apr 25, 2023
Closed
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Roadmap Apr 25, 2023
@wusyong wusyong moved this from 📋 Backlog to 📬Proposal in Roadmap Apr 29, 2023
@tankh99
Copy link

tankh99 commented Jul 6, 2024

Hi there, I'd like to help out with this issue. Is this issue being worked on by someone else?

@FabianLars
Copy link
Member

Not that we know off, but after the conversation here and in #5381 i'm not sure what the wanted approach is.

@Legend-Master Legend-Master mentioned this issue Nov 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers scope: core Core packages of Tauri status: backlog Issue is ready and we can work on it type: feature request
Projects
Roadmap
Status: 📬Proposal
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: allow setting window size and position using physical units close #5228 ysinsane/tauri
5 participants
@WilliamVenner @ysinsane @FabianLars @amrbashir @tankh99