Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable preferred codec #258

Open
Suxsem opened this issue May 8, 2024 · 0 comments
Open

Configurable preferred codec #258

Suxsem opened this issue May 8, 2024 · 0 comments

Comments

@Suxsem
Copy link

Suxsem commented May 8, 2024

Hi,
currently, the first codec is chosen as preferred codec:

pyVoIP/pyVoIP/RTP.py

Lines 313 to 318 in dd2c83c

Select the first available actual codec to encode with.
TODO: will need to change if video codecs
are ever implemented.
"""
self.preference = assoc[m]
break

Compatible codecs list is hardcoded in init.py, so preferred codec will always be PCMU

RTPCompatibleCodecs = [PayloadType.PCMU, PayloadType.PCMA, PayloadType.EVENT]

I need a way to use PCMA as preferred codec.

@tayler6000 I'm going to prepare a PR to add this feature, do you have any suggestion in how to expose this configuration? Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant