New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Off by one hour when daylight savings time ends #4

Closed

OJ7 opened this issue Nov 28, 2022 · 1 comment

Contributor

OJ7 commented Nov 28, 2022

My timings are currently one hour off (prayer times are one hour later than they should be) ever since daylight savings time ended in the US.

I found this issue in the library which I think this app uses that has the same issue I have.

In your code , I think you'll have to subtract 1 from the dst calculation due to that bug.

I haven't tested this out/created a PR myself as I don't have android development setup, but did some digging basic digging looking through the code.

OJ7 mentioned this issue

Add DST offset config #6

Merged

Contributor Author

OJ7 commented Dec 5, 2022

Addressed by #6

OJ7 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment