Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot read property _values of undefined #35

Open
AaronMT opened this issue May 12, 2021 · 4 comments
Open

Cannot read property _values of undefined #35

AaronMT opened this issue May 12, 2021 · 4 comments

Comments

@AaronMT
Copy link

AaronMT commented May 12, 2021

Hello, I am trying out your Github Action with a fairly simple workflow [1].

On the particular step for this action it yields: Cannot read property _values of undefined

[1] https://github.com/AaronMT/firefox-ios/blob/main/.github/workflows/build-contributor-pr.yml

The Xcodebuild step is running a test-plan of XCUITests from a particular scheme. I am not sure if analyze-xcoderesults-action is running into issues with this particular setup or if it's even supported. Thought I'd ask here. I assume it's having a problem parsing out the result bundle.

@tbartelmess
Copy link
Owner

Hi sorry you ran into issues.

Can you please try version 0.1.1. In your workflow file you are using 0.1.0.

@AaronMT
Copy link
Author

AaronMT commented May 13, 2021

That was it, thanks.

https://github.com/AaronMT/firefox-ios/runs/2577850126?check_suite_focus=true

(Aside, with successful output Github marked an ❌ here. With 50 tests passed / 0 failed, and the job finished successfully Github marked the job as failed)

Is this fixed on your newer tags?

(Is this it? 2239645)

@tbartelmess
Copy link
Owner

@AaronMT yeah that seems like a bug, I'll have a look tonight.

@AaronMT
Copy link
Author

AaronMT commented May 17, 2021

(Apologies for re-using the same issue, I can open a new one if need be)

Another issue seems to be that it is not always writing out the check on Github for some reason. For example, on a re-run today https://github.com/AaronMT/firefox-ios/runs/2602937245?check_suite_focus=true I was expecting Xcode Results on the left side. But on an earlier run this morning it worked https://github.com/AaronMT/firefox-ios/actions/runs/850381155 – no difference in results in my XCResult artifacts.

Run tbartelmess/[email protected]
  with:
    results: TestResults.xcresult
    GITHUB_TOKEN: ***
    pathPrefix: /Users/runner/work/firefox-ios/firefox-ios
    title: Test Results
    testSummaryTable: true
    testFailureAnnotations: true
    summary: true
    warningAnnotations: false
    showSDKInfo: true
  env:
    pythonLocation: /Users/runner/hostedtoolcache/Python/3.9.5/x64
Analyzing TestResults.xcresult ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants