From 1976e0fdac5359bd1698def2dbddf19a1573140a Mon Sep 17 00:00:00 2001 From: Tommaso Bossi Date: Mon, 12 Jul 2021 15:23:10 +0200 Subject: [PATCH] Build with ICU --- .github/workflows/build.yml | 16 +++++++--------- builders/v8-android-arm-v7.sh | 3 +-- builders/v8-android-arm-v8.sh | 3 +-- builders/v8-android-x86-64.sh | 3 +-- builders/v8-android-x86.sh | 3 +-- builders/v8-linux.sh | 3 +-- builders/v8-macos.sh | 3 +-- builders/v8-windows.cmd | 2 +- 8 files changed, 14 insertions(+), 22 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 33921624..2f365bb9 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -35,7 +35,7 @@ jobs: - uses: actions/upload-artifact@v2 with: name: linux_x86-64 - path: '~/v8/v8/out.gn/x64.release/*.so' + path: '~/v8/v8/out.gn/x64.release/' build_android_arm_v8: name: Android (arm64-v8a) @@ -50,7 +50,7 @@ jobs: - uses: actions/upload-artifact@v2 with: name: android_arm64-v8a - path: '~/v8/v8/out.gn/arm64.release/*.so' + path: '~/v8/v8/out.gn/arm64.release/' build_android_arm_v7: name: Android (armeabi-v7a) @@ -65,7 +65,7 @@ jobs: - uses: actions/upload-artifact@v2 with: name: android_armeabi-v7a - path: '~/v8/v8/out.gn/arm.release/*.so' + path: '~/v8/v8/out.gn/arm.release/' build_android_x86_64: name: Android (x86-64) @@ -80,7 +80,7 @@ jobs: - uses: actions/upload-artifact@v2 with: name: android_x86-64 - path: '~/v8/v8/out.gn/x64.release/*.so' + path: '~/v8/v8/out.gn/x64.release/' build_android_x86: name: Android (x86) @@ -95,7 +95,7 @@ jobs: - uses: actions/upload-artifact@v2 with: name: android_x86 - path: '~/v8/v8/out.gn/ia32.release/*.so' + path: '~/v8/v8/out.gn/ia32.release/' build_macos: name: macOS @@ -110,7 +110,7 @@ jobs: - uses: actions/upload-artifact@v2 with: name: macos - path: '~/v8/v8/out.gn/x64.release/*.dylib' + path: '~/v8/v8/out.gn/x64.release/' build_windows: name: Windows @@ -126,9 +126,7 @@ jobs: - uses: actions/upload-artifact@v2 with: name: windows - path: | - v8/v8/out.gn/x64.release/*.dll - v8/v8/out.gn/x64.release/*.lib + path: 'v8/v8/out.gn/x64.release/' headers_and_documentation: name: Headers and Documentation diff --git a/builders/v8-android-arm-v7.sh b/builders/v8-android-arm-v7.sh index cd0417cb..83b585eb 100644 --- a/builders/v8-android-arm-v7.sh +++ b/builders/v8-android-arm-v7.sh @@ -44,8 +44,7 @@ target_cpu = "arm" v8_target_cpu = "arm" is_component_build = true use_custom_libcxx = false -v8_enable_i18n_support = false -v8_use_snapshot = false +v8_enable_i18n_support = true v8_use_external_startup_data = false symbol_level = 1 ' diff --git a/builders/v8-android-arm-v8.sh b/builders/v8-android-arm-v8.sh index 6fcf11da..8c476797 100644 --- a/builders/v8-android-arm-v8.sh +++ b/builders/v8-android-arm-v8.sh @@ -44,8 +44,7 @@ target_cpu = "arm64" v8_target_cpu = "arm64" is_component_build = true use_custom_libcxx = false -v8_enable_i18n_support = false -v8_use_snapshot = false +v8_enable_i18n_support = true v8_use_external_startup_data = false symbol_level = 1 ' diff --git a/builders/v8-android-x86-64.sh b/builders/v8-android-x86-64.sh index 8e40c91e..7fac7ef2 100644 --- a/builders/v8-android-x86-64.sh +++ b/builders/v8-android-x86-64.sh @@ -44,8 +44,7 @@ target_cpu = "x64" v8_target_cpu = "x64" is_component_build = true use_custom_libcxx = false -v8_enable_i18n_support = false -v8_use_snapshot = false +v8_enable_i18n_support = true v8_use_external_startup_data = false symbol_level = 1 ' diff --git a/builders/v8-android-x86.sh b/builders/v8-android-x86.sh index e0ff0cc1..9ca68cc1 100644 --- a/builders/v8-android-x86.sh +++ b/builders/v8-android-x86.sh @@ -44,8 +44,7 @@ target_cpu = "x86" v8_target_cpu = "x86" is_component_build = true use_custom_libcxx = false -v8_enable_i18n_support = false -v8_use_snapshot = false +v8_enable_i18n_support = true v8_use_external_startup_data = false symbol_level = 1 ' diff --git a/builders/v8-linux.sh b/builders/v8-linux.sh index 3884d967..08306577 100644 --- a/builders/v8-linux.sh +++ b/builders/v8-linux.sh @@ -42,8 +42,7 @@ python ./tools/dev/v8gen.py x64.release -vv -- ' target_os = "linux" is_component_build = true use_custom_libcxx = false -v8_enable_i18n_support = false -v8_use_snapshot = false +v8_enable_i18n_support = true v8_use_external_startup_data = false symbol_level = 0 ' diff --git a/builders/v8-macos.sh b/builders/v8-macos.sh index 73030cd9..240821d6 100644 --- a/builders/v8-macos.sh +++ b/builders/v8-macos.sh @@ -30,8 +30,7 @@ python ./tools/dev/v8gen.py x64.release -vv -- ' target_os = "mac" is_component_build = true use_custom_libcxx = false -v8_enable_i18n_support = false -v8_use_snapshot = false +v8_enable_i18n_support = true v8_use_external_startup_data = false symbol_level = 0 ' diff --git a/builders/v8-windows.cmd b/builders/v8-windows.cmd index 4b19e81b..094fec0e 100644 --- a/builders/v8-windows.cmd +++ b/builders/v8-windows.cmd @@ -28,7 +28,7 @@ call git apply --ignore-whitespace --verbose %GITHUB_WORKSPACE%\builders\BUILD.g echo =====[ Building V8 ]===== -call python .\tools\dev\v8gen.py x64.release -vv -- target_os="""win""" is_component_build=true use_custom_libcxx=false is_clang=true use_lld=false v8_enable_verify_heap=false v8_enable_i18n_support=false v8_use_snapshot=false v8_use_external_startup_data=false symbol_level=0 +call python .\tools\dev\v8gen.py x64.release -vv -- target_os="""win""" is_component_build=true use_custom_libcxx=false is_clang=true use_lld=false v8_enable_verify_heap=false v8_enable_i18n_support=true v8_use_external_startup_data=false symbol_level=0 call ninja -C out.gn\x64.release -t clean call ninja -C out.gn\x64.release v8