Fixed empty relationship fields

tbruckmaier · Aug 13, 2023 · 5af1a8d · 5af1a8d
1 parent 531071a
commit 5af1a8d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/Models/Relationship.php b/src/Models/Relationship.php
@@ -17,6 +17,6 @@ public function getValueAttribute()
     {
         // it would be nice if we could implement this as a hasMany()
         // relation, but laravel does not support whereIn() in relationships
-        return $this->getSortedRelation(CorcelPost::class, $this->internal_value);
+        return $this->getSortedRelation(CorcelPost::class, $this->internal_value ?: []);
     }
 }
diff --git a/tests/FieldRelationshipTest.php b/tests/FieldRelationshipTest.php
@@ -19,4 +19,12 @@ public function testRelationshipField()
         $this->assertInstanceOf(Collection::class, $acfField->value);
         $this->assertEquals(['Post #0', 'Post #2', 'Post #1'], $acfField->value->pluck('post_title')->all());
     }
+    public function testRelationshipFieldEmpty()
+    {
+        $acfField = factory(Relationship::class)->create();
+        $this->addData($acfField, 'fake_relationship_object', "");
+
+        $this->assertInstanceOf(Collection::class, $acfField->value);
+        $this->assertEquals([], $acfField->value->all());
+    }
 }