-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Signal Beta in safe storage #62
Comments
Hi. Thank you very much! Your changes look great! However, I think a better approach is to introduce a |
I did initially consider that option but I wasn't sure if all platforms used the same pattern for Signal Beta. I should be able to update the branch to use a |
Ah, I see. Yes, it's the same pattern as far as I know.
Great! |
Hi @tbvdm, I've updated the branch and was able to test/validate again, it seems to work as expected. |
Looks good! Could you create a PR? |
Hi there,
sigtop
currently hardcodes"Signal"
as the app name for safe storage, but at least on MacOS, Signal and Signal Beta use a different safe storage:I've fixed this in my branch here, I can create a PR if you'd like.
The text was updated successfully, but these errors were encountered: