Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Signal Beta in safe storage #62

Open
jsutlovic opened this issue Oct 25, 2024 · 5 comments · May be fixed by #64
Open

Add support for Signal Beta in safe storage #62

jsutlovic opened this issue Oct 25, 2024 · 5 comments · May be fixed by #64

Comments

@jsutlovic
Copy link

Hi there,

sigtop currently hardcodes "Signal" as the app name for safe storage, but at least on MacOS, Signal and Signal Beta use a different safe storage:
Screenshot 2024-10-25 at 4 56 08 PM

I've fixed this in my branch here, I can create a PR if you'd like.

@tbvdm
Copy link
Owner

tbvdm commented Oct 28, 2024

Hi. Thank you very much! Your changes look great! However, I think a better approach is to introduce a -B flag that should change the app name to "Signal Beta" and also adjust the Signal directory (unless already specified with -d). I don't know if you're willing to adjust your fix, but if you are, that would be great!

@jsutlovic
Copy link
Author

I did initially consider that option but I wasn't sure if all platforms used the same pattern for Signal Beta. I should be able to update the branch to use a -B flag instead, though, I'll update once it's ready.

@tbvdm
Copy link
Owner

tbvdm commented Nov 6, 2024

I did initially consider that option but I wasn't sure if all platforms used the same pattern for Signal Beta.

Ah, I see. Yes, it's the same pattern as far as I know.

I'll update once it's ready.

Great!

@jsutlovic
Copy link
Author

Hi @tbvdm, I've updated the branch and was able to test/validate again, it seems to work as expected.

@tbvdm
Copy link
Owner

tbvdm commented Nov 14, 2024

Looks good! Could you create a PR?

@jsutlovic jsutlovic linked a pull request Nov 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants