-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should we support fractional minutes and hours? #65
Comments
@eemeli mentioned today that we should prioritize fractional digits up to hours. Here's how we can do it fairly elegantly.
The behavior for subsecond digits is as described in #64. When Arithmetic is required, but not any sort of fancy arithmetic like Temporal can perform. We just always assume exactly 60 seconds in a minute and exactly 60 minutes in an hour. |
One other possibility would be to add an option
|
At the possible cost of making things a bit more complicated, I do really like @eemeli's suggestion here. Either way, I think it's alright for |
This is not supported in the current version of the proposal, but could be easily done in a follow-on. |
I think there's not much to add here. Fractional minutes and hours could be added with minor changes but are not in the scope of the current proposal. Do folks agree it's fine to close this issue for now and move on? |
Largely a duplicate of #89 |
#64 discusses a new
fractionalDigits
option for seconds and lower. Should we support fractional minutes and hours as well? For example, "2.5 hours" or "2.5 minutes".The text was updated successfully, but these errors were encountered: