Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ToDateDurationRecordWithoutTime: CreateDateDurationRecord is infallible #3028

Closed
anba opened this issue Oct 30, 2024 · 0 comments
Closed

ToDateDurationRecordWithoutTime: CreateDateDurationRecord is infallible #3028

anba opened this issue Oct 30, 2024 · 0 comments
Assignees
@ptomato
Labels
editorial spec-text Specification text involved

Comments

@anba
Copy link
Contributor

anba commented Oct 30, 2024

ToDateDurationRecordWithoutTime is called with a Temporal.Duration object, which means the total number of seconds doesn't exceed 2^53. Therefore days can never get too large for CreateDateDurationRecord to fail.
@ptomato ptomato self-assigned this Dec 4, 2024
@ptomato ptomato added spec-text Specification text involved editorial labels Dec 4, 2024
ptomato added a commit that referenced this issue Dec 5, 2024
@ptomato
Editorial: ToDateDurationRecordWithoutTime is infallible
3d5a4cf 
The input is an existing valid Temporal.Duration object, which cannot have
a total of days through nanoseconds that exceeds the 2⁵³ limit. So days
cannot be out of range in the CreateDateDurationRecord call.

h/t Anba

Closes: #3028
@Ms2ger Ms2ger closed this as completed in 05017b9 Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ptomato ptomato

Labels
editorial spec-text Specification text involved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ptomato @anba