You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I just took a peek at how the language picker icon is implemented on this site and strangely found it amongst the HTML+Liquid in _layouts/menu.html while all the other SVG assets are located in the assets/img directory. The files located in that directory also have problems. For example, the menu-down.svg icon strangely includes a line indicating that Apple owns the copyright to it (view source).
I also discovered that several other optimizations could significantly reduce the size of all these SVGs. Compare this to a manually optimized one i made a while ago for some other project: https://codepen.io/DerekNonGeneric/pen/bGroexG.
We can even take this a step further by minifying the assets and can probably make additional corrections in the process (viewbox of TC39 logo seems off) and we should probably ensure all are following a11y best practices (accessible SVGs).
The text was updated successfully, but these errors were encountered:
I'm interested in improving around assets. It would be great to open a PR to lift us up to the first stage, but are you willing to do that? I'd love to see that.
I just took a peek at how the language picker icon is implemented on this site and strangely found it amongst the HTML+Liquid in
_layouts/menu.html
while all the other SVG assets are located in theassets/img
directory. The files located in that directory also have problems. For example, themenu-down.svg
icon strangely includes a line indicating that Apple owns the copyright to it (view source).I also discovered that several other optimizations could significantly reduce the size of all these SVGs. Compare this to a manually optimized one i made a while ago for some other project: https://codepen.io/DerekNonGeneric/pen/bGroexG.
We can even take this a step further by minifying the assets and can probably make additional corrections in the process (viewbox of TC39 logo seems off) and we should probably ensure all are following a11y best practices (accessible SVGs).
The text was updated successfully, but these errors were encountered: