Add version to migration file if rails5+ #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrations are versioned in Rails 5. Rails 5+ requires the rails version specified and throws an error during migration if not specified. Compatible with previous Rails versions
Add migration version in migration file if rails5+. Doesnt add if Rails::VERSION::MAJOR < 5.
add back migration_version
|
The Travis CI test for RAILS_VERSION=5.0.0.1 is failing. I thought it was the changes I made, I removed all code added by me and it was still failing. Looks like they are unrelated. I've added back my changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails5+ requires migration version included in the migration file superclass
eg: class ActsAsFollowerMigration < ActiveRecord::Migration[5.1]