Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

withdrawal/send: Support selecting custom sat per byte #447

Open
tiero opened this issue Nov 18, 2021 · 7 comments
Open

withdrawal/send: Support selecting custom sat per byte #447

tiero opened this issue Nov 18, 2021 · 7 comments
Assignees

Comments

@tiero
Copy link
Contributor

tiero commented Nov 18, 2021

At the moment we hardcoded to 0.1 sat per byte, if Liquid Network usage grows we must let the user decide

@Janaka-Steph
Copy link
Collaborator

Should it be a simple input, a slider?

@tiero tiero changed the title withdrawal: Support selecting custom sat per byte withdrawal/send: Support selecting custom sat per byte Feb 8, 2022
@ghost
Copy link

ghost commented Feb 9, 2022

Instead of slider I would like to use large buttons.

  • This is a similar approach to BlueWallet & GreenWallet.
  • People are already used to this UX pattern in GW (the most used liquid wallet).

ux-proposal

Please let me know if you would like a different direction @Janaka-Steph

@tiero
Copy link
Contributor Author

tiero commented Feb 9, 2022

Agreed. We can re-use the same modal component used in Settings > L-BTC Unit (without the search box)

@ghost
Copy link

ghost commented Feb 10, 2022

Perfect.

I've been getting familiarized with the codebase and setting up the environment these past two days. I'll submit a PR tomorrow morning to track the progress.

In the meantime I'll send you guys some screenshots of the UI I'm working on.

Screen Shot 2022-02-10 at 14 23 29

I like this approach because:

  • It is non-invasive.
  • It has a sane default.
  • It allows customization only if the user wants to.

@Janaka-Steph
Copy link
Collaborator

Maybe better to use the same button style as the Confirm button, but with border radius similar to address input field ?
If we keep this button style (background similar to inputs, no border), I would still change the border radius and align with the input.
"0.1 sat/vByte" small cap should be nicer.
When clicking on button we show "Fast, Medium, Slow" but they are all set to 0.1 ?
We don't support custom fee?
@tiero @librepgp

@ghost
Copy link

ghost commented Feb 11, 2022

Thanks for the feedback.

I'll do the custom fee like the second screenshot in BW.

At the bottom where it says "Personalizada" it means "Custom amount". You click it and then an input dialog pops up.

@ghost
Copy link

ghost commented Feb 11, 2022

I'm done with the second screen. Any feedback on this new screen would be great :D @Janaka-Steph

I'll make sure to include the changes you suggested in the first screen.

The "NETWORK FREE" label and the "SAT/VBYTE" button I added are actually aligned with the "MAX"/"FIAT VALUE" labels above. I'll change the alignment and test out the other changes as well.

screen2

screen1

@ghost ghost mentioned this issue Feb 12, 2022
6 tasks
@tdex-network tdex-network deleted a comment from Simo29 Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants