Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle lost connection to telegram servers gracefully #54

Open
luckydonald opened this issue Feb 15, 2021 · 6 comments
Open

Handle lost connection to telegram servers gracefully #54

luckydonald opened this issue Feb 15, 2021 · 6 comments

Comments

@luckydonald
Copy link
Collaborator

Currently, if telegram isn't working, requests are simply left open, stalling forever.

That's not great as that means basically DDoS potential.

To Reproduce:

  1. Lauch bot api
  2. Disconnect Wifi or whatever
  3. Send a request to the Bot API.
  4. ????
  5. Boom
@luckydonald
Copy link
Collaborator Author

So I think it should just return an error right away.
Just like the Internal Server Error: restart one.

@penn5
Copy link

penn5 commented Feb 15, 2021

@luckydonald I don't get it

@cavallium
Copy link
Member

It should work with the next update, I'm closing this issue. Reopen it if the problem exists also in the next update.

@luckydonald
Copy link
Collaborator Author

Any concrete commit fixing this?

@cavallium
Copy link
Member

cavallium commented Jun 28, 2021

Is still not working with the current release?

@luckydonald
Copy link
Collaborator Author

luckydonald commented Jun 28, 2021

No idea, didn't test yet.
I was rather curious by what it could be fixed now.

Like, did a upstream merge change that, or did one of you lovely people fix it?

@cavallium cavallium reopened this Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants