Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AC68080 is seen as only "FPGA" #1

Open
TuKo1982 opened this issue Nov 13, 2024 · 6 comments
Open

AC68080 is seen as only "FPGA" #1

TuKo1982 opened this issue Nov 13, 2024 · 6 comments

Comments

@TuKo1982
Copy link

Hi !

Many thanks for that great tool, it reminds me of one of my favorite one on Windows :)

Regarding AC68080 detection, would it be possible to improve it and not just display "FPGA" ? Identify.library has all required infos since some versions now.

Thanks in advance !

Best Regards

@tdolphin-org
Copy link
Owner

Are You sure that identify.library do it?
Could You provide some screenshot with those values reported by identify.library?
You can use Huh from alb42
https://blog.alb42.de/2024/11/02/huh-0-1-a-simple-mui-gui-for-identify-library/

@TuKo1982
Copy link
Author

Manuf is 5016 and cards can be identified with it

IDs available here beginning from line 1497 : https://github.com/shred/identify/blob/master/src/identify/ID_Database.s

SAGA chipset is identified correctly, which is already great

@tdolphin-org
Copy link
Owner

Ok. It is possible to combine more infos on CPU-tab. Currently there is all info which are returned by identify related to CPU.

But maybe It would better to update identify.library to return new type of CPU (IDHW_CPU)? like:

#define IDCPU_FPGA_68080 (11) /* FPGA based CPU 68080 */

Than all applications which are using this library will gain from this update.

This is also question to author of identify.library @shred

@tdolphin-org tdolphin-org pinned this issue Nov 19, 2024
@tdolphin-org
Copy link
Owner

Since 0.3.0 version, I have added distinguish AC68080 when FPGA detected.
@TuKo1982
Could test it?

@shred
Copy link

shred commented Jan 20, 2025

Hi... I'm sorry for my late answer.

I think it's a good idea that identify returns "68080" if FPGA and SAGA chipset is detected. I will also add it to the next release.

@TuKo1982
Copy link
Author

Since 0.3.0 version, I have added distinguish AC68080 when FPGA detected. @TuKo1982 Could test it?

It works perfectly ! It might be tuned for spitting our more infos, I will have a look at it and make you a pull request.

Many thanks !

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants