Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unusable in darkmode #12

Closed
sn55997 opened this issue Apr 28, 2024 · 5 comments
Closed

unusable in darkmode #12

sn55997 opened this issue Apr 28, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@sn55997
Copy link

sn55997 commented Apr 28, 2024

Cant read the add-on window in thunderbird's darkmode
image

@tdulcet tdulcet added enhancement New feature or request good first issue Good for newcomers labels Apr 28, 2024
@tdulcet
Copy link
Owner

tdulcet commented Apr 28, 2024

Thanks for the bug report. The regular dark mode works for me:
image

I believe the issue is that you also enabled the high contrast mode, which is not yet supported by the library this add-on uses for the CSS. See TinyWebEx/AutomaticSettings#23 for more information.

@sn55997
Copy link
Author

sn55997 commented Apr 28, 2024

Sorry for the double post and thanks for the quick reply.

High contrast mode is not enabled! BUT: I changed the colours in Preferences>Fonts&Colours as this is the only way to get the message preview window to work in dark mode. This should not affect the options window of any add-on, but it does in some add-ons (e.g. ReplyWithHeader). If the colour preferences are set to default, dark mode works as expected in the FileLink provider for Send. But I do not want the light message preview. (Changing the forced-colours and prefers-contrast tags did not work.) So it does not seem to be caused by your code, but the "FileLink provider for box" e.g. does not have this problem in the Preferences>Compose>Attachments window. Any ideas?

image image
image

@tdulcet
Copy link
Owner

tdulcet commented Apr 29, 2024

Thanks for the detailed information and screenshots. My understanding is that using that override in Thunderbird has the same effect as enabling high contrast mode, so adding support for high contrast mode should resolve the issue for you. See the discussion in rugk/awesome-emoji-picker#131, where another user had this same issue with an add-on I help maintain.

Note that Thunderbird 128 is scheduled to have support for automatically converting light message content to dark (see bug 1715361), which would allow you to have dark messages without needing to enable this override. Long term, the CSS in the library will need to be updated to support high contrast mode. I do not have the CSS knowledge to make the changes myself (which is why I use a library), so I will leave this issue open until we find a volunteer.

@sn55997
Copy link
Author

sn55997 commented Apr 29, 2024

Thanks a lot, this was very helpful!

@tdulcet tdulcet removed the good first issue Good for newcomers label Sep 3, 2024
@tdulcet
Copy link
Owner

tdulcet commented Sep 11, 2024

This should be fixed in Thunderbird 128.

@tdulcet tdulcet closed this as completed Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants