-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TG2-AMENDMENT_ESTABLISHMENTMEANS_STANDARDIZED #269
Comments
The Notes are in error. "Unknown" is not a valid value for the vocabulary. The corresponding standard controlled value "uncertain " and the preferred label "uncertain (unknown, cryptogenic)". See https://dwc.tdwg.org/em/. |
Like #268, maybe this should also be regarded as CORE now that there is a suitable Vocabulary. Again it received a rating of 6.5. |
Thanks @tucotuco - correct. I was misreading and going by memory. I've deleted the Note. |
@ArthurChapman I would concur, it makes good sense to include in core, some of the data quality needs elicited by TG3 do involve invasive species and the movement of species, so with vocabularies these tests do feel in scope for core. |
I've removed the Note as we seem to agree this is now CORE. |
The four tests (#277, #278, #268, #269) should be CORE (I have discussed this with Lee). Some reasons are
|
We should be using the following value for the source authority: bdq:sourceAuthority default = "Establishment Means Controlled Vocabulary List of Terms" {[https://dwc.tdwg.org/em/]} {GBIF vocabulary API [https://api.gbif.org/v1/vocabularies/EstablishmentMeans/]} See: #268 (comment) |
Thanks @chicoreus - Changing Source Authority from [bdq:sourceAuthority default = "Darwin Core establishmentMeans" {[https://dwc.tdwg.org/list/#dwc_establishmentMeans]} {dwc:establishmentMeans vocabulary API [https://api.gbif.org/v1/vocabularies/EstablishmentMeans/concepts]} to bdq:sourceAuthority default = "Establishment Means Controlled Vocabulary List of Terms" {[https://dwc.tdwg.org/em/]} {GBIF vocabulary API [https://api.gbif.org/v1/vocabularies/EstablishmentMeans/]} |
I think https://api.gbif.org/v1/vocabularies/EstablishmentMeans/concepts is OK as a source authority because it actually has an API, as long as it is understood that the actually vocabulary is maintained at https://dwc.tdwg.org/em/ and the GBIF API is expected to remain up to date with that. |
https://api.gbif.org/v1/vocabularies/EstablishmentMeans/concepts added back in. Dunno why it was changed back. |
Changed Source Authority from bdq:sourceAuthority default = "Establishment Means Controlled Vocabulary List of Terms" {[https://dwc.tdwg.org/em/]} {GBIF vocabulary API [https://api.gbif.org/v1/vocabularies/EstablishmentMeans/concepts]} to bdq:sourceAuthority default = "GBIF EstablishmentMeans Vocabulary" [https://api.gbif.org/v1/vocabularies/EstablishmentMeans]} {"dwc:establishmentMeans vocabulary API" [https://api.gbif.org/v1/vocabularies/EstablishmentMeans/concepts]} |
Source Authority should be bdq:sourceAuthority default = "Establishment Means Controlled Vocabulary List of Terms" {[https://dwc.tdwg.org/em/]} {GBIF vocabulary API [https://api.gbif.org/v1/vocabularies/EstablishmentMeans/concepts]} |
Changed Source Authority from bdq:sourceAuthority default = "GBIF EstablishmentMeans Vocabulary" [https://api.gbif.org/v1/vocabularies/EstablishmentMeans]} {"dwc:establishmentMeans vocabulary API" [https://api.gbif.org/v1/vocabularies/EstablishmentMeans/concepts]} to bdq:sourceAuthority default = "Establishment Means Controlled Vocabulary List of Terms" {[https://dwc.tdwg.org/em/]} {GBIF vocabulary API [https://api.gbif.org/v1/vocabularies/EstablishmentMeans/concepts]} |
The first example should be corrected to match the controlled vocabulary, and a disamiguation case that can be resolved from the controlled vocabulary, thus "Native" instead of "native" and "Native (Indigenous)" instead of "indigenous": [dwc:establishmentMeans="Native (Indigenous)": Response.status=AMENDED, Response.result=dwc:establishmentMeans="Native", Response.comment="dwc:establishmentMeans contains an interpretable value according to the bdq:sourceAuthority"] |
Looking harder, this is actually a problem with the GBIF controlled vocabulary, it differs from the the TDWG vocabulary in case. The correct value is "native", not "Native". Implementors will have to be aware that the expected value needs to be an exact match to the TDWG vocabulary. This applies to several tests. [dwc:establishmentMeans="Native (Indigenous)": Response.status=AMENDED, Response.result=dwc:establishmentMeans="native", Response.comment="dwc:establishmentMeans contains an interpretable value according to the bdq:sourceAuthority"] |
Since a ratified controlled vocabulary actually exists, we should urge GBIF to amend their implementation of the vocabulary. |
See #275 (comment) The GBIF API is only of partial help here, it does not provide the actual Controlled Values from the TDWG vocabulary, the values it has differ in case, implementations can use the GBIF API for its additional values, but need to align the case to match the actual Controlled Value from the TDWG vocabulary for the dwc: term values (GBIF API is sufficient for the dwciri term values). |
@tucotuco I agree. |
GBIF vocabulary has now been aligned with Darwin Core. Thanks @timrobertson100 |
…hmentMeans amendment and validation along with default methods and unit tests.
…#276 and tdwg/bdq#278 to recognized variants of controlled vocabulary terms.
…ng matching method to pass. Probably needs to be extended to the other wider net cases.
The text was updated successfully, but these errors were encountered: