New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Pub/Sub and Cloud Function #48

Draft

felix-datatonic wants to merge 2 commits into develop from refactor/remove-cloudfunction

Collaborator

felix-datatonic commented Jan 19, 2024 •

edited

Loading

Description

remove Pub/Sub & Cloud Function from Terraform
update Cloud Scheduler to trigger HTTP (instead of Pub/Sub)
update docs & architecture diagram
remove trigger tests and Cloud Function code
remove Contribution.md as this is rather a duplication of content for setting infrastructure

TODO:

display name isn't populated when using HTTP to create pipeline job
caching option doesn't exist in REST API

How has this been tested?

Please explain how you have tested the new changes.

Checklist

I have commented my code, particularly in hard-to-understand areas
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
I have successfully run the E2E tests
I have updated any relevant documentation to reflect my changes

felix-datatonic added 2 commits

January 18, 2024 15:00


          Remove Pub/Sub and Cloud Function

5f867d8


          Update docs

45bccab

Collaborator Author

felix-datatonic commented Jan 19, 2024

/gcbrun

1 similar comment

Collaborator Author

felix-datatonic commented Feb 7, 2024

/gcbrun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet