From e497f286b64447c52229e3e98ca320490ae78836 Mon Sep 17 00:00:00 2001 From: LEE YOU BIN Date: Tue, 19 Nov 2024 22:14:04 +0900 Subject: [PATCH 1/4] [FEAT/#300] version update 1.1.7 -> 1.1.8 --- gradle/libs.versions.toml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml index 45ae80bb..48738241 100644 --- a/gradle/libs.versions.toml +++ b/gradle/libs.versions.toml @@ -2,8 +2,8 @@ compileSdk = "34" minSdk = "28" targetSdk = "34" -versionName = "1.1.7" -versionCode = "10107" +versionName = "1.1.8" +versionCode = "10108" kotlinCompilerExtensionVersion = "1.5.0" jvmTarget = "1.8" From 615ada1ddec9616b7c2a284ecd93b2f8a3ea84c1 Mon Sep 17 00:00:00 2001 From: LEE YOU BIN Date: Wed, 20 Nov 2024 00:21:01 +0900 Subject: [PATCH 2/4] =?UTF-8?q?[FEAT/#300]=20=ED=84=B0=EB=8B=9D=20?= =?UTF-8?q?=EC=8B=9C=EC=9E=91=ED=95=98=EA=B8=B0=20=EC=97=A0=ED=94=8C?= =?UTF-8?q?=EB=A6=AC=ED=8A=9C=EB=93=9C=20=EC=9D=B4=EB=B2=A4=ED=8A=B8?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../filtering/startfiltering/StartFilteringRoute.kt | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/feature/src/main/java/com/terning/feature/filtering/startfiltering/StartFilteringRoute.kt b/feature/src/main/java/com/terning/feature/filtering/startfiltering/StartFilteringRoute.kt index 9c3d8c97..6c3fd530 100644 --- a/feature/src/main/java/com/terning/feature/filtering/startfiltering/StartFilteringRoute.kt +++ b/feature/src/main/java/com/terning/feature/filtering/startfiltering/StartFilteringRoute.kt @@ -26,6 +26,8 @@ import androidx.compose.ui.unit.dp import androidx.hilt.navigation.compose.hiltViewModel import androidx.lifecycle.compose.collectAsStateWithLifecycle import com.airbnb.lottie.compose.LottieConstants +import com.terning.core.analytics.EventType +import com.terning.core.analytics.LocalTracker import com.terning.core.designsystem.component.button.RectangleButton import com.terning.core.designsystem.component.item.TerningLottieAnimation import com.terning.core.designsystem.theme.TerningPointTheme @@ -44,13 +46,21 @@ fun StartFilteringRoute( val configuration = LocalConfiguration.current val screenHeight = 780f / configuration.screenHeightDp + val amplitudeTracker = LocalTracker.current + LaunchedEffect(key1 = true) { delay(DELAY) viewModel.updateButtonState() } StartFilteringScreen( - onNextClick = onNextClick, + onNextClick = { + onNextClick() + amplitudeTracker.track( + type = EventType.CLICK, + name = "click_start_service" + ) + }, buttonState = state.isButtonVisible, screenHeight = screenHeight, ) From ea8813e62eab3212374b26880f6ef7c8d3928312 Mon Sep 17 00:00:00 2001 From: LEE YOU BIN Date: Wed, 20 Nov 2024 00:30:00 +0900 Subject: [PATCH 3/4] =?UTF-8?q?[FEAT/#300]=20=ED=83=90=EC=83=89=20?= =?UTF-8?q?=EB=B0=B0=EB=84=88=20=EC=97=A0=ED=94=8C=EB=A6=AC=ED=8A=9C?= =?UTF-8?q?=EB=93=9C=20=EC=9D=B4=EB=B2=A4=ED=8A=B8?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../java/com/terning/feature/search/search/SearchRoute.kt | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/feature/src/main/java/com/terning/feature/search/search/SearchRoute.kt b/feature/src/main/java/com/terning/feature/search/search/SearchRoute.kt index 27d081b1..f26df6f2 100644 --- a/feature/src/main/java/com/terning/feature/search/search/SearchRoute.kt +++ b/feature/src/main/java/com/terning/feature/search/search/SearchRoute.kt @@ -94,7 +94,12 @@ fun SearchRoute( }, navigateToIntern = navigateToIntern, onAdvertisementClick = { pageIndex -> - CustomTabsIntent.Builder().build().launchUrl(context, SearchViewModel.bannerList[pageIndex].url.toUri()) + amplitudeTracker.track( + type = EventType.CLICK, + name = "click_quest_bannner" + ) + CustomTabsIntent.Builder().build() + .launchUrl(context, SearchViewModel.bannerList[pageIndex].url.toUri()) } ) } From 01e2a50d37c6ba38511d48cb7185ab5bad4c8705 Mon Sep 17 00:00:00 2001 From: LEE YOU BIN Date: Wed, 20 Nov 2024 00:46:16 +0900 Subject: [PATCH 4/4] =?UTF-8?q?[FEAT/#300]=20=EB=8B=A4=EC=9D=B4=EC=96=BC?= =?UTF-8?q?=EB=A1=9C=EA=B7=B8=20=EC=97=A0=ED=94=8C=EB=A6=AC=ED=8A=9C?= =?UTF-8?q?=EB=93=9C=20=EC=9D=B4=EB=B2=A4=ED=8A=B8?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../java/com/terning/feature/dialog/detail/ScrapDialog.kt | 8 +++++++- .../filtering/startfiltering/StartFilteringRoute.kt | 2 +- .../java/com/terning/feature/search/search/SearchRoute.kt | 2 +- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/feature/src/main/java/com/terning/feature/dialog/detail/ScrapDialog.kt b/feature/src/main/java/com/terning/feature/dialog/detail/ScrapDialog.kt index 8e64ca23..8068d46d 100644 --- a/feature/src/main/java/com/terning/feature/dialog/detail/ScrapDialog.kt +++ b/feature/src/main/java/com/terning/feature/dialog/detail/ScrapDialog.kt @@ -138,7 +138,13 @@ fun ScrapDialog( ) } }, - onClickNavigateButton = viewModel::navigateToDetail, + onClickNavigateButton = { + viewModel.navigateToDetail() + amplitudeTracker.track( + type = EventType.CLICK, + name = "modal_detail" + ) + }, onClickScrapButton = { amplitudeTracker.track( type = EventType.CLICK, diff --git a/feature/src/main/java/com/terning/feature/filtering/startfiltering/StartFilteringRoute.kt b/feature/src/main/java/com/terning/feature/filtering/startfiltering/StartFilteringRoute.kt index 6c3fd530..c82e4943 100644 --- a/feature/src/main/java/com/terning/feature/filtering/startfiltering/StartFilteringRoute.kt +++ b/feature/src/main/java/com/terning/feature/filtering/startfiltering/StartFilteringRoute.kt @@ -58,7 +58,7 @@ fun StartFilteringRoute( onNextClick() amplitudeTracker.track( type = EventType.CLICK, - name = "click_start_service" + name = "start_service" ) }, buttonState = state.isButtonVisible, diff --git a/feature/src/main/java/com/terning/feature/search/search/SearchRoute.kt b/feature/src/main/java/com/terning/feature/search/search/SearchRoute.kt index f26df6f2..7b4303d6 100644 --- a/feature/src/main/java/com/terning/feature/search/search/SearchRoute.kt +++ b/feature/src/main/java/com/terning/feature/search/search/SearchRoute.kt @@ -96,7 +96,7 @@ fun SearchRoute( onAdvertisementClick = { pageIndex -> amplitudeTracker.track( type = EventType.CLICK, - name = "click_quest_bannner" + name = "quest_banner" ) CustomTabsIntent.Builder().build() .launchUrl(context, SearchViewModel.bannerList[pageIndex].url.toUri())