Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch more than 30 forks #13

Open
Newgap opened this issue Oct 10, 2018 · 10 comments
Open

Fetch more than 30 forks #13

Newgap opened this issue Oct 10, 2018 · 10 comments
Labels

Comments

@Newgap
Copy link

Newgap commented Oct 10, 2018

Forks from GitHub are paged 30 at a time. It would be nice to fetch them all for large projects (many forks).

@techgaun
Copy link
Owner

@Newgap thats a good point. Would be open for a PR from community as I have couple of busy weeks.

@Syed-Umair
Copy link
Contributor

I will work on this.

@techgaun
Copy link
Owner

all yours @Syed-Umair

@Syed-Umair
Copy link
Contributor

@techgaun, Do you need me to load specific amount of forks data like 100 or all that is available.

@techgaun
Copy link
Owner

techgaun commented Oct 10, 2018

@Syed-Umair I think the best would be to follow the guidelines and put lazy loading or page numbering at the bottom of the page: https://developer.github.com/v3/guides/traversing-with-pagination/

You should be able to use the Link headers information to do this

@Syed-Umair
Copy link
Contributor

Ok, I will do that.

@Newgap
Copy link
Author

Newgap commented Oct 11, 2018

Don't forget that if we change the sorting, you will need to refetch the data from GitHub with that new sorting. Or, you can fetch all data in memory and sort that instead.

@techgaun
Copy link
Owner

@Newgap agreed. I am however not sure if we really want to fetch all data. For examle, facebook/react has 20K forks and not sure how helpful/useful would it be to pull them all. But, again, for something like such repos, this tool might not be used as often and could be potential trade-off? Just not sure what would be the best way to get around this. Thoughts?

@ModischFabrications
Copy link

Can we set the number of forks to be fetched via UI instead of using a max of 100 like in #14? I usually use this tool to find the fork with the latest commit, which is impossible or at least very luck-based with repos with more than 100 forks.

@techgaun
Copy link
Owner

@ModischFabrications fair point. That's probably a good idea. Will try to get that in soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants