Applied versioning code to set path in com_api (resource.php) library… #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… itself This is to set resource path if there is version provided in API url.
|
Can you apply code formatting and make sure the code passes PHPCS validation. Also the type for the version should be float, currently is CMD (default) |
|
I have added only 4 lines and they are well formatted. I didn't get what you want me to do for code formatting. Used online code sniffer, that doesn't give me major errors. Also when I am using type FLOAT then if version contains value 1.0, it returns only 1, So I removed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… itself
This is to set resource path if there is version provided in API url.