Skip to content

Commit 3709b38

Browse files
committed
going in circles but everything works now
1 parent 00f1c4f commit 3709b38

File tree

3 files changed

+11
-13
lines changed

3 files changed

+11
-13
lines changed

server/fake_data.py

+4-6
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ def _generate_response(email: Email, thread: Thread):
7373
increment_response_count(documents)
7474

7575

76-
def generate_fake_email(generate_response=True):
76+
def generate_fake_email():
7777
"""Generate fake email."""
7878
thread = Thread()
7979
db.session.add(thread)
@@ -101,11 +101,10 @@ def generate_fake_email(generate_response=True):
101101
thread.resolved = False
102102
db.session.commit()
103103

104-
if generate_response:
105-
_generate_response(email, thread)
104+
_generate_response(email, thread)
106105

107106

108-
def generate_fake_thread(generate_response=True):
107+
def generate_fake_thread():
109108
"""Generate fake unresolved thread."""
110109
thread = Thread()
111110
db.session.add(thread)
@@ -199,5 +198,4 @@ def generate_fake_thread(generate_response=True):
199198
thread.resolved = False
200199
db.session.commit()
201200

202-
if generate_response:
203-
_generate_response(email_5, thread)
201+
_generate_response(email_5, thread)

server_tests/conftest.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ def app(db_url: str, redis_host: str):
7777

7878
with app.app_context():
7979
from server_tests.utils import seed_database
80-
seed_database(app)
80+
seed_database()
8181

8282
yield app
8383

server_tests/utils.py

+6-6
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
import logging
44

5-
from apiflask import APIFlask
65
from werkzeug.test import TestResponse
76

87

@@ -17,11 +16,12 @@ def assert_status(response: TestResponse, status: int):
1716
)
1817
raise
1918

20-
def seed_database(app: APIFlask):
19+
def seed_database():
2120
"""Seeds the database with some fake data."""
2221

23-
with app.app_context():
24-
from server.fake_data import generate_fake_thread, generate_test_documents
22+
from server.fake_data import generate_fake_thread, generate_test_documents
23+
from server.nlp.embeddings import embed_corpus
2524

26-
generate_test_documents()
27-
generate_fake_thread(generate_response=False)
25+
test_documents = generate_test_documents()
26+
embed_corpus(test_documents)
27+
generate_fake_thread()

0 commit comments

Comments
 (0)