Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop fedora-39 from the test configuration #3518

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Drop fedora-39 from the test configuration #3518

wants to merge 5 commits into from

Conversation

psss
Copy link
Collaborator

@psss psss commented Feb 10, 2025

The fedora-39 release is now end-of-life so let's speed-up the testing a bit.

Fix #3510.

@psss psss added this to the 1.43 milestone Feb 10, 2025
@psss psss added test coverage Improvements or additions to test coverage of tmt itself ci | full test Pull request is ready for the full test execution labels Feb 10, 2025
happz
happz reviewed Feb 10, 2025
View reviewed changes
tests/unit/main.fmf Outdated Show resolved Hide resolved
@happz
Copy link
Collaborator

happz commented Feb 10, 2025

@psss Makefile needs an update to, it will keep building the image.

@psss
Copy link
Collaborator Author

psss commented Feb 11, 2025

@psss Makefile needs an update to, it will keep building the image.

Good, point, fixed in 856bb00.

@psss psss requested a review from happz February 11, 2025 08:10
@lukaszachy
Copy link
Collaborator

/plans/provision/container/ansible fail
/tests/finish/ansible on

  • /container-fedora-39-upstream-latest-Test-Ansible-playbook and

/tests/prepare/ansible on

  • /container-fedora-39-upstream-latest-local-Test-Ansible-playbook
  • /container-fedora-39-upstream-latest-remote-Test-Ansible-playbook

/plans/provision/container/install fail
/tests/prepare/install on
/container-fedora-39-upstream*

lukaszachy
lukaszachy requested changes Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@lukaszachy lukaszachy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few tests still want to be run for f39 container

@psss
Copy link
Collaborator Author

psss commented Feb 11, 2025

Yeah, one more file needed to be changed. Should be fixed by 17c9865.

@psss psss requested a review from lukaszachy February 11, 2025 12:51
@lukaszachy
Copy link
Collaborator

Grep found more 39 usage, I'll add commit soon

@lukaszachy
Copy link
Collaborator

@psss please check 2a8169f, I don't see any other f39 usage.

lukaszachy
lukaszachy reviewed Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@lukaszachy lukaszachy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about removing the 'if fedora_39' checks. They bring historical value but at the same time are already obsoleted.

@psss
Copy link
Collaborator Author

psss commented Feb 11, 2025

@psss please check 2a8169f, I don't see any other f39 usage.

Thanks, looks good!

@psss
Copy link
Collaborator Author

psss commented Feb 11, 2025

I'm not sure about removing the 'if fedora_39' checks. They bring historical value but at the same time are already obsoleted.

Yeah, I would drop them.

@psss psss requested a review from lukaszachy February 12, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@happz happz happz approved these changes

@thrix thrix Awaiting requested review from thrix thrix is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

@martinhoyer martinhoyer Awaiting requested review from martinhoyer martinhoyer is a code owner

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
ci | full test Pull request is ready for the full test execution test coverage Improvements or additions to test coverage of tmt itself
Projects
None yet
Milestone
1.43
Development

Successfully merging this pull request may close these issues.

Drop Fedora 39 as a testing environment in tmt test suite
3 participants
@psss @happz @lukaszachy