Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove prepare/install fields leaking into prepare step data #2986

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Remove prepare/install fields leaking into prepare step data #2986

merged 2 commits into from
Jun 28, 2024

Conversation

happz
Copy link
Collaborator

@happz happz commented Jun 4, 2024

Pull Request Checklist

  • implement the feature
  • write the documentation
  • extend the test coverage
  • update the specification
  • adjust plugin docstring
  • modify the json schema
  • mention the version
  • include a release note

@happz happz added code | type annotations Related to type annotations and type cleanup code | style Code style changes not affecting functionality code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. labels Jun 4, 2024
@happz happz added this to the 1.35 milestone Jun 4, 2024
@happz happz mentioned this pull request Jun 4, 2024
Merged
6 tasks
@skycastlelily
Copy link
Collaborator

I failed to find anything Not perfect, so to prove that I do have review this MR carefully,I'd like to suggest: add a help message to how : The method name step uses ^^

@psss
Copy link
Collaborator

psss commented Jun 27, 2024

Looks good, let's rebase and merge to unblock #2985?

@happz happz added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Jun 27, 2024
@happz happz force-pushed the fix-raw-prepare-step-data-typing-mess branch from ed8803c to 1e137cb Compare June 27, 2024 11:40
@happz happz added the ci | full test Pull request is ready for the full test execution label Jun 27, 2024
@happz
Copy link
Collaborator Author

happz commented Jun 27, 2024

/packit build

@happz
Copy link
Collaborator Author

happz commented Jun 28, 2024

Unrelated failures, merging.

@happz happz merged commit 1bc2cb9 into main Jun 28, 2024
18 of 19 checks passed
@happz happz deleted the fix-raw-prepare-step-data-typing-mess branch June 28, 2024 13:08
The-Mule pushed a commit to The-Mule/tmt that referenced this pull request Oct 14, 2024
@happz @The-Mule
Remove prepare/install fields leaking into prepare step data (teemtee…
d8f030c 
…#2986)

* Remove prepare/install fields leaking into prepare step data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therazix therazix therazix approved these changes

@skycastlelily skycastlelily skycastlelily approved these changes

@psss psss Awaiting requested review from psss psss is a code owner

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@thrix thrix Awaiting requested review from thrix thrix is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

Assignees
No one assigned
Labels
ci | full test Pull request is ready for the full test execution code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. code | style Code style changes not affecting functionality code | type annotations Related to type annotations and type cleanup status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish.
Projects
None yet
Milestone
1.35
Development

Successfully merging this pull request may close these issues.
4 participants
@happz @skycastlelily @psss @therazix