From 206d84e1cb479589f4504cbd12c2c75bf4e23f66 Mon Sep 17 00:00:00 2001
From: Robert Stoll <robert.stoll@tegonal.com>
Date: Sun, 20 Oct 2024 21:08:17 +0200
Subject: [PATCH] fix beforePr fail-fast

---
 scripts/before-pr.sh | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/scripts/before-pr.sh b/scripts/before-pr.sh
index 93fc97b9..72a9e8f7 100755
--- a/scripts/before-pr.sh
+++ b/scripts/before-pr.sh
@@ -29,13 +29,12 @@ sourceOnce "$scriptsDir/cleanup-on-push-to-main.sh"
 sourceOnce "$scriptsDir/run-shellcheck.sh"
 
 function beforePr() {
-	runShellspecIfInstalled
-
 	# using && because this function is used on the left side of an || in releaseFiles
 	# this way we still have fail fast behaviour and don't mask/hide a non-zero exit code
-	checkInBugTemplate && \
-	customRunShellcheck && \
-	cleanupOnPushToMain
+	runShellspecIfInstalled &&
+		checkInBugTemplate &&
+		customRunShellcheck &&
+		cleanupOnPushToMain
 }
 
 ${__SOURCED__:+return}